RFR: 8373253: Re-work InjectGCWorkerCreationFailure for future changes [v5]
Stefan Karlsson
stefank at openjdk.org
Mon Jan 19 13:31:45 UTC 2026
On Mon, 19 Jan 2026 13:27:24 GMT, Leo Korinth <lkorinth at openjdk.org> wrote:
>> This PR slightly changes when we may `InjectGCWorkerCreationFailure`. At the moment we wait until `is_init_completed()`. I am changing this to instead be after `_created_workers > 0`. The reason is that we might in the future, https://bugs.openjdk.org/browse/JDK-8367993, create even more threads "on demand", and if so, we would fail VM creation if we inject worker creation failures after the VM is initiated but before we have created any of the worker threads.
>>
>> This change should not change the current behaviour. But help future improvements.
>>
>> I have tested this on `test/hotspot/jtreg/gc/stress/gcold/TestGCOldWithG1.java`, the only place where this flag is tested to my knowledge.
>
> Leo Korinth has updated the pull request incrementally with one additional commit since the last revision:
>
> rename of method
Marked as reviewed by stefank (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/28719#pullrequestreview-3678088509
More information about the hotspot-gc-dev
mailing list