RFR: 8375622: G1: Convert G1CodeRootSet to use Atomic<T>
Aleksey Shipilev
shade at openjdk.org
Mon Jan 19 15:40:26 UTC 2026
On Mon, 19 Jan 2026 11:35:39 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:
> Hi all,
>
> please review this change to convert `G1CodeRootSet` to use `Atomic<T>` instead of `AtomicAccess`.
>
> Testing: gha,
>
> Thanks,
> Thomas
Looks fine with nit.
src/hotspot/share/gc/g1/g1CodeRootSet.hpp line 29:
> 27:
> 28: #include "code/codeCache.hpp"
> 29: #include "runtime/atomic.hpp"
Yeah, but why here? The `Atomic<size_t>` is fully in `.cpp`, so better include in there, instead of (potentially popular) header?
-------------
PR Review: https://git.openjdk.org/jdk/pull/29296#pullrequestreview-3678649724
PR Review Comment: https://git.openjdk.org/jdk/pull/29296#discussion_r2705247477
More information about the hotspot-gc-dev
mailing list