Integrated: 8373253: Re-work InjectGCWorkerCreationFailure for future changes
Leo Korinth
lkorinth at openjdk.org
Tue Jan 20 09:33:03 UTC 2026
On Tue, 9 Dec 2025 13:39:54 GMT, Leo Korinth <lkorinth at openjdk.org> wrote:
> This PR slightly changes when we may `InjectGCWorkerCreationFailure`. At the moment we wait until `is_init_completed()`. I am changing this to instead be after `_created_workers > 0`. The reason is that we might in the future, https://bugs.openjdk.org/browse/JDK-8367993, create even more threads "on demand", and if so, we would fail VM creation if we inject worker creation failures after the VM is initiated but before we have created any of the worker threads.
>
> This change should not change the current behaviour. But help future improvements.
>
> I have tested this on `test/hotspot/jtreg/gc/stress/gcold/TestGCOldWithG1.java`, the only place where this flag is tested to my knowledge.
This pull request has now been integrated.
Changeset: c5f288e2
Author: Leo Korinth <lkorinth at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/c5f288e2ae2ebe6ee4a0d39d91348f746bd0e353
Stats: 16 lines in 2 files changed: 15 ins; 0 del; 1 mod
8373253: Re-work InjectGCWorkerCreationFailure for future changes
Reviewed-by: stefank, tschatzl, iwalulya, sjohanss
-------------
PR: https://git.openjdk.org/jdk/pull/28719
More information about the hotspot-gc-dev
mailing list