RFR: 8341630: G1: Adopt PartialArrayState to consolidate marking stack in concurrent marking [v3]
Stefan Johansson
sjohanss at openjdk.org
Tue Jan 20 11:11:17 UTC 2026
On Tue, 20 Jan 2026 11:00:13 GMT, Ivan Walulya <iwalulya at openjdk.org> wrote:
>> Hi,
>>
>> Please review this change which adopts the `PartialArrayState` mechanism for G1 concurrent marking.
>>
>> The `PartialArrayState` mechanism can push multiple continuations to the task queues, so it also solves the single-continuation limitation issue in [JDK-8167480](https://bugs.openjdk.org/browse/JDK-8167480).
>>
>> Testing: Mach5 Tier 1-3.
>
> Ivan Walulya has updated the pull request incrementally with one additional commit since the last revision:
>
> kstefanj refactor rename
Looks good, but I realized there was an additional opportunity for streamlining the naming. Do the below change if you agree.
src/hotspot/share/gc/g1/g1ConcurrentMark.hpp line 905:
> 903:
> 904: // Scans an object and visits its children.
> 905: inline void scan_task_entry(G1TaskQueueEntry task_entry, bool stolen);
Suggestion:
inline void process_entry(G1TaskQueueEntry task_entry, bool stolen);
-------------
Marked as reviewed by sjohanss (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/29249#pullrequestreview-3681630599
PR Review Comment: https://git.openjdk.org/jdk/pull/29249#discussion_r2707868691
More information about the hotspot-gc-dev
mailing list