RFR: 8375966: G1: Convert G1UpdateRegionLivenessAndSelectForRebuildTask to use Atomic<T>
Kim Barrett
kbarrett at openjdk.org
Wed Jan 21 16:43:51 UTC 2026
On Wed, 21 Jan 2026 10:56:51 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:
> Hi all,
>
> please review this change to convert `G1UpdateRegionLivenessAndSelectForRebuildTask` to use `Atomic<T>`.
>
> Testing: gha
>
> Thanks,
> Thomas
Looks good, with an optional whitespace adjustment.
src/hotspot/share/gc/g1/g1ConcurrentMarkRemarkTasks.hpp line 61:
> 59: void work(uint worker_id) override;
> 60:
> 61: uint total_selected_for_rebuild() const { return _total_selected_for_rebuild.load_relaxed(); }
Consider adding some line breaks to make this not such a long line.
-------------
Marked as reviewed by kbarrett (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/29340#pullrequestreview-3688256831
PR Review Comment: https://git.openjdk.org/jdk/pull/29340#discussion_r2713411963
More information about the hotspot-gc-dev
mailing list