RFR: 8375314: Parallel: Crash iterating over unloaded classes for ObjectCountAfterGC event [v2]
Roman Kennke
rkennke at openjdk.org
Thu Jan 22 07:42:32 UTC 2026
On Wed, 21 Jan 2026 16:32:21 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:
>> Hi all,
>>
>> please review this change that avoids crashes when gathering `ObjectCountAfterGC` JFR statisics.
>>
>> The cause for the crash is that the code purges metaspace after class unloading/purging after https://bugs.openjdk.org/browse/JDK-8361404. The heap iteration code walks the heap with classes that were unloaded and purged, eventually crashing if for some reason the data is invalid due to metaspace purging potentially uncommitting memory.
>>
>> Since it is somewhat ugly that we walk objects with dead klasses in them (as it was before the mentioned change), I moved the iteration to after the heap has been compacted, skipping filler objects that might be in there.
>>
>> Unfortunately I did not manage to write a good reproducer.
>>
>> Testing: gha, tier1-5, test case succeeding
>>
>> Thanks,
>> Thomas
>
> Thomas Schatzl has updated the pull request incrementally with one additional commit since the last revision:
>
> * remove WhiteBox references from test, not needed any more
The change looks good, thank you!
-------------
Marked as reviewed by rkennke (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/29318#pullrequestreview-3691037431
More information about the hotspot-gc-dev
mailing list