RFR: 8375981: G1: Convert G1RemSet helper classes to use Atomic<T> [v2]
Thomas Schatzl
tschatzl at openjdk.org
Thu Jan 22 09:34:53 UTC 2026
On Thu, 22 Jan 2026 09:23:20 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> Thomas Schatzl has updated the pull request incrementally with one additional commit since the last revision:
>>
>> * shade review
>
> src/hotspot/share/gc/g1/g1RemSet.cpp line 234:
>
>> 232: // either.
>> 233: }
>> 234: cur = next;
>
> Wait a second, is it really the same? `next` is from fetch-then-add, so it is "old" value? Original code re-reads `_cur_dirty_regions`, which looks more like "new" value after fetch-then-add?
Thanks for catching this. Fixed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29345#discussion_r2716066124
More information about the hotspot-gc-dev
mailing list