RFR: 8375747: ZGC: ZForwardingTest is unable to commit memory on Windows [v2]

Robert Toyonaga duke at openjdk.org
Wed Jan 28 21:29:05 UTC 2026


On Wed, 28 Jan 2026 21:14:06 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> The ZForwardingTest gtest first reserves memory via the ZGC APIs to do so and then uses the generic `os::commit_memory(...)` to commit the memory. That is problematic on Windows because the two APIs are not compatible there. I've updated the test to use ZGC's APIs to commit and map memory instead.
>> 
>> Thanks to @roberttoyonaga for finding this and helping out diagnosing this issue!
>> 
>> The patch also adds some tiny fixes to the assert code that mislead me while prototyping this.
>> 
>> I'll run this through tier1 testing.
>
> Stefan Karlsson has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Restructure setup and teardown

Thanks! This looks good to me.

-------------

Marked as reviewed by roberttoyonaga at github.com (no known OpenJDK username).

PR Review: https://git.openjdk.org/jdk/pull/29471#pullrequestreview-3719245366


More information about the hotspot-gc-dev mailing list