<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
<br>
Poonam and Jesper,<br>
<br>
Thanks for the prompt reviews! In theory I am all set now, but since
I think this is runtime code it would be great if I could get a
review from someone on the runtime team as well.<br>
<br>
It's a really small change, so a review should be fast...<br>
<br>
Thanks,<br>
Bengt<br>
<br>
On 2011-08-23 12:58, Poonam Bajaj wrote:
<blockquote cite="mid:4E5387CF.2050809@oracle.com" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
Looks good!<br>
<br>
Thanks,<br>
Poonam<br>
<br>
On 8/23/2011 2:56 PM, Bengt Rutisson wrote:
<blockquote cite="mid:4E53724B.90408@oracle.com" type="cite"><br>
Hi all, <br>
<br>
Could I please have a couple of reviews for this small fix?
After the
secure dll loading fix (7016797) the psapi.lib library is needed
for
Windows builds. The original change made sure that this library
is
provided to the linker for the command line builds. However, the
builds
from inside Visual Studio also need to know about this library.
<br>
<br>
Webrev: <br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Ebrutisso/7082220/webrev/">http://cr.openjdk.java.net/~brutisso/7082220/webrev/</a>
<br>
<br>
CR: <br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://monaco.us.oracle.com/detail.jsf?cr=7082220">http://monaco.us.oracle.com/detail.jsf?cr=7082220</a>
<br>
<br>
Testing: <br>
I created a Visual Studio project with the create script and
with the
change above the project builds nicely. <br>
<br>
I am including both Runtime and GC in this mail. The change is
to
runtime code, but I would like to push this through hotspot-gc.
The
reason is that this is blocking my work. Whenever I am setting
up a new
repository I run into this issue. But it seems that I am the
only one
who uses the Visual Studio builds at the moment. The issue has
been
around for several months but it only got integrated into
hsx/hotspot-gc 5 days ago. So, for me it would be easier to
integrate
directly into hotspot-gc and start using the fix rather than
having to
wait for the fix to propagate from hotspot-rt to hotspot-gc. <br>
<br>
Thanks, <br>
Bengt <br>
</blockquote>
<div class="moz-signature">
<p> <!-- This signature was generated by the MyDesktop Oracle Business Signature utility version 3.8.5 -->
</p>
</div>
</blockquote>
<br>
</body>
</html>