<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hi Jon,<br>
<br>
On 10/28/2011 12:11 AM, Jon Masamitsu wrote:
<blockquote cite="mid:4EA9A5EB.1030707@oracle.com" type="cite">
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
<br>
<br>
On 10/27/11 02:49, <a moz-do-not-send="true"
class="moz-txt-link-abbreviated"
href="mailto:poonam.bajaj@oracle.com">poonam.bajaj@oracle.com</a>
wrote:
<blockquote cite="mid:4EA92924.1050000@oracle.com" type="cite">
<meta content="text/html; charset=UTF-8"
http-equiv="Content-Type">
Hi Jon,<br>
<br>
I looked at some of the files and here are few comments:<br>
<br>
- concurrentMarkSweepGeneration.cpp, line 5551<br>
<br>
Here, flag UseDynamicNumberOfGCThreads can be checked to make
the decision if we need to use 'active_workers', the way you
have done it in collectionSetChooser.cpp at line 258<br>
</blockquote>
<br>
What I meant to say was that at 5551 I wanted to use whatever
value of<br>
active_workers that was calculated when calc_active_workers() was
last<br>
called. That would likely be the value at the last young GC or at
the<br>
initial-mark. I had at one point thought there was a dependency
between<br>
the number of GC threads used in a young collection and the number
used<br>
in the remark. I've been told that is not the case but have not
proven<br>
that to myself and since lots of testing has already been done
with this<br>
code, I left it unchanged with a note to myself to look at it
again.<br>
<br>
Did I understand your comment?<br>
</blockquote>
<br>
Yes.<br>
<br>
So, if the active_workers was not set then we will not calculate the<br>
active_workers with calc_active_workers() again and instead <br>
use ParallelGCThreads.<br>
<br>
Where in the code are the active_workers set for initial-marking <br>
phase?<br>
<br>
<blockquote cite="mid:4EA9A5EB.1030707@oracle.com" type="cite">
<blockquote cite="mid:4EA92924.1050000@oracle.com" type="cite"> <br>
- concurrentMarkSweepGeneration.cpp at line 5899<br>
<br>
same as above comment<br>
</blockquote>
<br>
My intent was to set a number of GC workers for a <br>
collection (minor or full or initial-mark or remark)<br>
so didn't want to change within the collection (Reference<br>
processing being done as part of the remark) so that's<br>
why I'm here just using what has previously been <br>
calculated.<br>
<br>
</blockquote>
Ok.<br>
<br>
<blockquote cite="mid:4EA9A5EB.1030707@oracle.com" type="cite"> <br>
<blockquote cite="mid:4EA92924.1050000@oracle.com" type="cite"> <br>
- concurrentMarkSweepGeneration.cpp, line 5552<br>
<br>
Mis-spelled in comments, "active_works" should be
"active_workers"<br>
</blockquote>
<br>
Fixed.<br>
</blockquote>
<br>
Thanks,<br>
Poonam<br>
<br>
<br>
<blockquote cite="mid:4EA9A5EB.1030707@oracle.com" type="cite"> <br>
Thanks.<br>
<br>
Jon<br>
<blockquote cite="mid:4EA92924.1050000@oracle.com" type="cite"> <br>
<br>
Thanks,<br>
Poonam<br>
<br>
<br>
On 10/27/2011 4:41 AM, Jon Masamitsu wrote:
<blockquote cite="mid:4EA893B9.7070905@oracle.com" type="cite">6593758:
RFE: Enhance GC ergonomics to dynamically choose
ParallelGCThreads <br>
<br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Ejmasa/6593758/webrev.00/">http://cr.openjdk.java.net/~jmasa/6593758/webrev.00/</a>
<br>
<br>
Thanks. <br>
<br>
<br>
</blockquote>
<br>
<div class="moz-signature">-- <br>
Best regards, Poonam
<p> <a moz-do-not-send="true" href="http://www.oracle.com"
target="_blank"><img
src="cid:part1.09090104.09090203@oracle.com"
alt="Oracle" border="0" height="26" width="114"></a><br>
<font color="#666666" face="Verdana, Arial, Helvetica,
sans-serif" size="2">Poonam Bajaj | Principal Member of
Technical Staff<br>
Phone: <a moz-do-not-send="true"
href="tel:+91%2080%2066937451">+91 80 66937451</a> |
Mobile: <a moz-do-not-send="true"
href="tel:+91%209844511366">+91 9844511366</a> <br>
<font color="#ff0000">Oracle</font> JVM Sustaining
Engineering<br>
<br>
ORACLE India Bangalore</font> <br>
<a moz-do-not-send="true"
href="http://www.oracle.com/commitment" target="_blank"><img
src="cid:part2.07050104.08010008@oracle.com" alt="Green
Oracle" align="absmiddle" border="0" height="28"
width="44"></a> <font color="#4B7D42" face="Verdana,
Arial, Helvetica, sans-serif" size="1">Oracle is committed
to developing practices and products that help protect the
environment</font>
<!-- This signature was generated by the MyDesktop Oracle Business Signature utility version 3.8.7 -->
</p>
</div>
</blockquote>
</blockquote>
<br>
<div class="moz-signature">-- <br>
Best regards, Poonam
<p>
<a href="http://www.oracle.com" target="_blank"><img
src="cid:part3.04010907.02070403@oracle.com" alt="Oracle"
border="0" height="26" width="114"></a><br>
<font color="#666666" face="Verdana, Arial, Helvetica,
sans-serif" size="2">Poonam Bajaj | Principal Member of
Technical Staff<br>
Phone: <a href="tel:+91%2080%2066937451">+91 80 66937451</a>
| Mobile: <a href="tel:+91%209844511366">+91 9844511366</a> <br>
<font color="#ff0000">Oracle</font> JVM Sustaining Engineering<br>
<br>
ORACLE India Bangalore</font>
<br>
<a href="http://www.oracle.com/commitment" target="_blank"><img
src="cid:part4.03090202.06040303@oracle.com" alt="Green
Oracle" align="absmiddle" border="0" height="28" width="44"></a>
<font color="#4B7D42" face="Verdana, Arial, Helvetica,
sans-serif" size="1">Oracle is committed to developing
practices and products that help protect the environment</font>
<!-- This signature was generated by the MyDesktop Oracle Business Signature utility version 3.8.7 -->
</p>
</div>
</body>
</html>