<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<br>
On 11/4/2011 8:47 PM, Tony Printezis wrote:
<blockquote cite="mid:4EB40213.4040408@oracle.com" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
Poonam, I removed the notion of "GC alloc region" with 7039627.
Are you looking at a recent workspace?<br>
<br>
</blockquote>
Oh..ok. No, I was looking at the jdk7 hotspot and not the latest
one. So, please ignore that comment, and the changes look fine to
me.<br>
<br>
regards,<br>
Poonam<br>
<br>
<blockquote cite="mid:4EB40213.4040408@oracle.com" type="cite"> Tony<br>
<br>
On 11/3/2011 8:38 PM, <a moz-do-not-send="true"
class="moz-txt-link-abbreviated"
href="mailto:poonam.bajaj@oracle.com">poonam.bajaj@oracle.com</a>
wrote:
<blockquote cite="mid:4EB333E9.7030108@oracle.com" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
Hi Tony,<br>
<br>
The changes and the output looks good!<br>
<br>
I noticed in heapRegion.cpp (in HeapRegion::print() ) that 'A'
for GC Alloc region can also appear in the HeapRegion output, so
would be good to add the meaning of A too in the header.<br>
<br>
Thanks,<br>
Poonam<br>
<br>
<br>
On 11/3/2011 9:57 PM, Tony Printezis wrote:
<blockquote cite="mid:4EB2C0FB.8030308@oracle.com" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
Poonam,<br>
<br>
Latest webrev is here:<br>
<br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Etonyp/7099849/webrev.1/webrev.all/">http://cr.openjdk.java.net/~tonyp/7099849/webrev.1/webrev.all/</a><br>
<br>
This is what I changed compared to the previous one:<br>
<br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Etonyp/7099849/webrev.1/webrev.1.G1HSErrExtra/">http://cr.openjdk.java.net/~tonyp/7099849/webrev.1/webrev.1.G1HSErrExtra/</a><br>
<br>
I decided to also add "TS" before the GC time stamp on every
line so that I can describe what that that value is.
(universe.hpp has the white space changes Bengt asked for)<br>
<br>
This is some example output:<br>
<br>
Heap<br>
garbage-first heap total 32768K, used 21540K [0xace00000,
0xaee00000, 0xaee00<br>
000)<br>
region size 1024K, 4 young (4096K), 2 survivors (2048K)<br>
compacting perm gen total 16384K, used 2663K [0xaee00000,
0xafe00000, 0xb2e000<br>
00)<br>
the space 16384K, 16% used [0xaee00000, 0xaf099fe8,
0xaf09a000, 0xafe00000)<br>
No shared spaces configured.<br>
<br>
Heap Regions: (Y=young(eden), SU=young(survivor),
HS=humongous(starts), HC=humongous(continues), CS=collection
set, F=free, TS=gc time stamp, PTAMS=previous
top-at-mark-start, NTAMS=next top-at-mark-start)<br>
F TS 17 PTAMS 0xace00000 NTAMS 0xace00000 space
1024K, 0% used [0xace00000, 0xace00000, 0xacf00000)<br>
TS 11 PTAMS 0xacf00000 NTAMS 0xad000000 space
1024K, 100% used [0<br>
...<br>
<br>
and I also attached the full hs_err file.<br>
<br>
Better?<br>
<br>
Tony<br>
<br>
On 11/01/2011 10:08 AM, <a moz-do-not-send="true"
class="moz-txt-link-abbreviated"
href="mailto:poonam.bajaj@oracle.com">poonam.bajaj@oracle.com</a>
wrote:
<blockquote cite="mid:4EAFFD45.1070906@oracle.com" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
Hi Tony,<br>
<br>
I hope I am not too late in providing feedback on this
change. Here are couple of suggestions for the heap regions
information in hs_err file:<br>
<br>
- I think it would be useful to print a header before the
heap regions details. e.g.<br>
<br>
Heap<br>
garbage-first heap total 20480K, used 11630K [0x6e600000,
0x6fa00000, 0xae600000)<br>
region size 1024K, 1 young (1024K), 1 survivors (1024K)<br>
compacting perm gen total 16384K, used 2604K [0xae600000,
0xaf600000, 0xb2600000)<br>
the space 16384K, 15% used [0xae600000, 0xae88b3c0,
0xae88b400, 0xaf600000)<br>
No shared spaces configured.<br>
<br>
<b>Heap Regions:</b><br>
0 PTAMS 0x6e600000 NTAMS 0x6e639700 space
1024K, 22% used [0x6e600000, 0x6e639700, 0x6e700000)<br>
F 17 PTAMS 0x6e700000 NTAMS 0x6e700000 space
1024K, 0% used [0x6e700000, 0x6e700000, 0x6e800000)<br>
F 17 PTAMS 0x6e800000 NTAMS 0x6e800000 space
1024K, 0% used [0x6e800000, 0x6e800000, 0x6e900000)<br>
<br>
<br>
- Also, I think it would be helpful for the hs_err file
reader to have the meanings of the acronyms also printed (as
we show in the stack trace in hs_err file)<br>
<br>
Native frames: (J=compiled Java code, j=interpreted, Vv=VM
code, C=native code)<br>
V [libjvm.so+0xc494db] VMError::report_and_die()+0x19b<br>
<br>
Heap Regions: (CS=collection set, PTAMS=previous top at mark
start, NTAMS=next top at mark start, etc...)<br>
17 PTAMS 0x6f200000 NTAMS 0x6f300000 space
1024K, 100% used [0x6f200000, 0x6f300000, 0x6f300000)<br>
CS SU 17 PTAMS 0x6f300000 NTAMS 0x6f38e650 space
1024K, 55% used [0x6f300000, 0x6f38e650, 0x6f400000)<br>
17 PTAMS 0x6f400000 NTAMS 0x6f493c60 space
1024K, 57% used [0x6f400000, 0x6f493c60, 0x6f500000)<br>
<br>
<br>
<br>
Thanks,<br>
Poonam<br>
<br>
<br>
On 10/12/2011 10:19 PM, Tony Printezis wrote:
<blockquote cite="mid:4E95C529.3070909@oracle.com"
type="cite">Hi all, <br>
<br>
(I'm also copying the runtime alias, as this change will
concern them too) <br>
<br>
I'd like to get a couple of reviews for this change: <br>
<br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Etonyp/7099849/webrev.0/">http://cr.openjdk.java.net/~tonyp/7099849/webrev.0/</a>
<br>
<br>
Some background: when trying to track down issues in G1 it
is often very helpful to know what type of regions the
heap has and/or get information on a particular region
(whether it's humongous, whether it's young, how full it
is, etc.). We thought it'd be a good idea to include the
per-region information in the hs_err file to always have
it available after a crash. <br>
<br>
I don't think the changes in the webrev are too
controversial. The reason I wanted to give a heads up to
both groups was to point out that this change will
increase the size of the hs_err files when G1 is used.
It's common to have 1,000 to 2,000 regions in the heap, if
larger heaps are used (much fewer if smaller heaps are
used), which means that the hs_err file will have this
many extra lines. Does anyone have any concerns about
this? <br>
<br>
I attached an example hs_err file obtained from a
workspace with this change applied. <br>
<br>
BTW, I also cleaned up a bit the way the print() methods
on the heap are defined (I pushed the default behavior to
the superclass, where possible). <br>
<br>
Tony <br>
<br>
</blockquote>
<br>
<div class="moz-signature">-- <br>
Best regards, Poonam
<p> <a moz-do-not-send="true"
href="http://www.oracle.com" target="_blank"><img
src="cid:part1.08030800.03070800@oracle.com"
alt="Oracle" border="0" height="26" width="114"></a><br>
<font color="#666666" face="Verdana, Arial, Helvetica,
sans-serif" size="2">Poonam Bajaj | Principal Member
of Technical Staff<br>
Phone: <a moz-do-not-send="true"
href="tel:+91%2080%2066937451">+91 80 66937451</a> |
Mobile: <a moz-do-not-send="true"
href="tel:+91%209844511366">+91 9844511366</a> <br>
<font color="#ff0000">Oracle</font> JVM Sustaining
Engineering<br>
<br>
ORACLE India Bangalore</font> <br>
<a moz-do-not-send="true"
href="http://www.oracle.com/commitment"
target="_blank"><img
src="cid:part2.07020401.06060608@oracle.com"
alt="Green Oracle" align="absmiddle" border="0"
height="28" width="44"></a> <font color="#4B7D42"
face="Verdana, Arial, Helvetica, sans-serif" size="1">Oracle
is committed to developing practices and products that
help protect the environment</font>
<!-- This signature was generated by the MyDesktop Oracle Business Signature utility version 3.8.7 -->
</p>
</div>
</blockquote>
</blockquote>
<br>
<div class="moz-signature">-- <br>
Best regards, Poonam
<p> <a moz-do-not-send="true" href="http://www.oracle.com"
target="_blank"><img
src="cid:part3.05080007.06050908@oracle.com"
alt="Oracle" border="0" height="26" width="114"></a><br>
<font color="#666666" face="Verdana, Arial, Helvetica,
sans-serif" size="2">Poonam Bajaj | Principal Member of
Technical Staff<br>
Phone: <a moz-do-not-send="true"
href="tel:+91%2080%2066937451">+91 80 66937451</a> |
Mobile: <a moz-do-not-send="true"
href="tel:+91%209844511366">+91 9844511366</a> <br>
<font color="#ff0000">Oracle</font> JVM Sustaining
Engineering<br>
<br>
ORACLE India Bangalore</font> <br>
<a moz-do-not-send="true"
href="http://www.oracle.com/commitment" target="_blank"><img
src="cid:part4.02010106.07000209@oracle.com" alt="Green
Oracle" align="absmiddle" border="0" height="28"
width="44"></a> <font color="#4B7D42" face="Verdana,
Arial, Helvetica, sans-serif" size="1">Oracle is committed
to developing practices and products that help protect the
environment</font>
<!-- This signature was generated by the MyDesktop Oracle Business Signature utility version 3.8.7 -->
</p>
</div>
</blockquote>
</blockquote>
<br>
<div class="moz-signature">-- <br>
Best regards, Poonam
<p>
<a href="http://www.oracle.com" target="_blank"><img
src="cid:part5.06090203.09050604@oracle.com" alt="Oracle"
border="0" height="26" width="114"></a><br>
<font color="#666666" face="Verdana, Arial, Helvetica,
sans-serif" size="2">Poonam Bajaj | Principal Member of
Technical Staff<br>
Phone: <a href="tel:+91%2080%2066937451">+91 80 66937451</a>
| Mobile: <a href="tel:+91%209844511366">+91 9844511366</a> <br>
<font color="#ff0000">Oracle</font> JVM Sustaining Engineering<br>
<br>
ORACLE India Bangalore</font>
<br>
<a href="http://www.oracle.com/commitment" target="_blank"><img
src="cid:part6.07010801.08030108@oracle.com" alt="Green
Oracle" align="absmiddle" border="0" height="28" width="44"></a>
<font color="#4B7D42" face="Verdana, Arial, Helvetica,
sans-serif" size="1">Oracle is committed to developing
practices and products that help protect the environment</font>
<!-- This signature was generated by the MyDesktop Oracle Business Signature utility version 3.8.7 -->
</p>
</div>
</body>
</html>