<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Thanks Ramki.<br>
<br>
dl<br>
<br>
On 2/14/2012 4:30 PM, Srinivas Ramakrishna wrote:
<blockquote
cite="mid:CABzyjynsO0QtUokrRSwEpGcwq3j6hOsfO3x3Z3=O3wRptZ5BHg@mail.gmail.com"
type="cite">Looks good to me.<br>
<br>
-- ramki (openjdk: ysr)<br>
<br>
<div class="gmail_quote">On Mon, Feb 13, 2012 at 2:09 PM, Dean
Long <span dir="ltr"><<a moz-do-not-send="true"
href="mailto:dean.long@oracle.com">dean.long@oracle.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex"><a
moz-do-not-send="true"
href="http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7140866"
target="_blank">http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7140866</a><br>
<br>
<a moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Edlong/7140866/webrev.00/"
target="_blank">http://cr.openjdk.java.net/~dlong/7140866/webrev.00/</a><br>
<br>
The problem happens when trying to use a shared archive. If
for some reason mapping the shared file fails,<br>
we call<br>
<br>
_rs->resize_covered_region(MemRegion(shared_bottom,
shared_bottom));<br>
<br>
to undo the earlier call to<br>
<br>
_rs->resize_covered_region(MemRegion(readonly_bottom,
readwrite_end));<br>
<br>
Unfortunately the resize code is not prepared to deal with a
zero-sized region so an assert fails.<br>
Rather than touch the resize code, this fix changes the caller
to only call resize_covered_region()<br>
once after the shared file is mapped.<br>
<br>
Tested fix on a particular linux arm platform where the mmap
fails 100% of the time due to a different issue.<br>
Ran -Xshare:dump first then a few GC tests.<span
class="HOEnZb"><font color="#888888"><br>
<br>
dl<br>
</font></span></blockquote>
</div>
<br>
</blockquote>
</body>
</html>