<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
<br>
Jon,<br>
<br>
Looks good to me too.<br>
<br>
Thanks for doing this refactoring!<br>
<br>
One question: I think hotspot normally does not use the "get_"
prefix for getters. Is it worth changing that too for the methods
that you are now renaming (e.g. FreeList::get_chunk_at_head(),
BinaryTreeDictionary<Chunk>::get_chunk_from_tree(),
FreeBlockDictionary::get_chunk()).<br>
<br>
I am perfectly fine with the change as it is now. Just thought I'd
ask.<br>
<br>
Bengt<br>
<br>
On 2012-04-25 08:33, Srinivas Ramakrishna wrote:
<blockquote
cite="mid:CABzyjymEOJ4mXNH889uAGj2KEPuhT5eVih6ur=qxCA+ewFvonA@mail.gmail.com"
type="cite">Looks good to me, and sorry for the trouble this
caused (mea culpa)... I hope you had an automatic refactoring
feature in your IDE to make it a bit less painful<br>
than manual modifications of so many names.<br>
<br>
-- ramki<br>
<br>
<div class="gmail_quote">On Tue, Apr 24, 2012 at 11:09 PM, Jon
Masamitsu <span dir="ltr"><<a moz-do-not-send="true"
href="mailto:jon.masamitsu@oracle.com">jon.masamitsu@oracle.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt
0.8ex; border-left: 1px solid rgb(204, 204, 204);
padding-left: 1ex;">
7164144: Fix variable naming style in freeBlockDictionary.*
and binaryTreeDictionary*<br>
<br>
The naming style in some CMS code is different from the<br>
the predominate style in hotspot. Some of the CMS classes
have<br>
recently been generalized for wider use. This change
normalizes<br>
the naming in those classes.<br>
<br>
These changes are strictly name changes.<br>
<br>
<a moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Ejmasa/7164144/webrev.00/"
target="_blank">http://cr.openjdk.java.net/~jmasa/7164144/webrev.00/</a><br>
</blockquote>
</div>
<br>
</blockquote>
<br>
</body>
</html>