<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
<br>
Hi Vitaly,<br>
<br>
Thanks for looking at this!<br>
<br>
On 2012-05-07 15:31, Vitaly Davidovich wrote:
<blockquote
cite="mid:CAHjP37HyytpoO+zqN-BMP9xJ8tGTGEtf3nryRVRPhtpAOEAQpw@mail.gmail.com"
type="cite">
<p>Hi Bengt,</p>
<p>The allocation of the buffer to hold the string and sprintf'ing
to it is repeated at the places you changed. Do you think it's
worth it to factor that out into a common function or maybe some
stack allocated class whose destructor would free the message
buffer? Just a thought ...</p>
</blockquote>
<br>
I see your point, but I'm not sure this would actually simplify the
code.<br>
<br>
<blockquote
cite="mid:CAHjP37HyytpoO+zqN-BMP9xJ8tGTGEtf3nryRVRPhtpAOEAQpw@mail.gmail.com"
type="cite">
<p>Also, probably better to use snprintf instead of sprintf.</p>
</blockquote>
<br>
Good point. I'll fix this. This code fragment is actually copied
from existing G1 code, so I'll go back and change that too.<br>
<br>
Thanks again for looking at it!<br>
Bengt<br>
<br>
<blockquote
cite="mid:CAHjP37HyytpoO+zqN-BMP9xJ8tGTGEtf3nryRVRPhtpAOEAQpw@mail.gmail.com"
type="cite">
<p>Regards,</p>
<p>Vitaly</p>
<p>Sent from my phone</p>
<div class="gmail_quote">On May 7, 2012 8:35 AM, "Bengt Rutisson"
<<a moz-do-not-send="true"
href="mailto:bengt.rutisson@oracle.com">bengt.rutisson@oracle.com</a>>
wrote:<br type="attribution">
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt
0.8ex; border-left: 1px solid rgb(204, 204, 204);
padding-left: 1ex;">
<br>
Hi all,<br>
<br>
Can I get a couple of reviews of this simple change:<br>
<a moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Ebrutisso/7166894/webrev/"
target="_blank">http://cr.openjdk.java.net/~brutisso/7166894/webrev/</a><br>
<br>
Background:<br>
I recently pushed a similar fix for G1 as "7163848: G1: Log GC
Cause for a GC". That fix adds the GC cause information to all
G1 GCs. It was discussed if we should do this for all
collectors and we came to the conclusion that it would be
fairly safe to do it for all Full GCs. These log messages
already contain the text "(System)" or "(System.gc())" when a
System.gc() happens and PrintGCDetails are enabled. Now they
will always contain the cause in parenthesis, even when only
PrintGC is enabled. Hopefully most parsing will work with
this.<br>
<br>
Thanks,<br>
Bengt<br>
</blockquote>
</div>
</blockquote>
<br>
</body>
</html>