<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html;charset=ISO-8859-1" http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
Hi Thomas,<br>
<br>
I would rather not remove the HRRS_VERBOSE code. It has proven to be
invaluable in the past when debugging the dreaded "missing entry in
remembered set" failure. So as potential candidate for investigating an
error like this in the future - I would like to keep the code in place
rather than recreate it. I'm OK with not using conditional compilation
and using a 'develop' flag as suggested by Bengt.<br>
<br>
Anyway a new webrev based upon your latest patch can be found at:
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~johnc/6921087/webrev.1/">http://cr.openjdk.java.net/~johnc/6921087/webrev.1/</a><br>
<br>
Thanks,<br>
<br>
JohnC<br>
<br>
On 06/21/12 09:04, Thomas Schatzl wrote:
<blockquote cite="mid:1340294664.7888.3.camel@gremio" type="cite">
<pre wrap="">Hi,
On Thu, 2012-06-21 at 12:27 +0200, Bengt Rutisson wrote:
</pre>
<blockquote type="cite">
<pre wrap="">John and Thomas,
I think we should try to remove dead code and I consider code that has
been #if-deffed out for several years dead. So, I'm all for removing
both PRT_COUNT_OCCUPIED and SAMPLE_FOR_EVICTION. All our testing and
performance measurements have been based on these being enabled. Let's
remove the unused code for having those flags disabled.
A bit more tricky question is HRRS_VERBOSE. I am not sure why this is a
#define and not a develop flag. In my opinion we can remove that too
along with the code it guards since HRRS_VERBOSE is disabled. On the
other hand this is just logging so it would also be fine to turn
HRRS_VERBOSE into a develop flag. Personally I prefer to remove the code
and add it in again later if we see the need for it.
</pre>
</blockquote>
<pre wrap=""><!---->
I totally agree. Attached is a diff that removes the ifdef's and
defines using the current values, and fixes the copyright year in the
header.
Tested with a few specjbb runs only.
Thomas
</pre>
</blockquote>
<br>
</body>
</html>