<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix"><br>
Hi Vitaly,<br>
<br>
Thanks for looking at this.<br>
<br>
On 2012-08-22 14:27, Vitaly Davidovich wrote:<br>
</div>
<blockquote
cite="mid:CAHjP37EOidy8g09s-RBS1EYw7XyHDHqnyQnTgee1JJTV5txDkw@mail.gmail.com"
type="cite">
<p>Looks good. One small typo:</p>
<p>experimental(uintx, G1OldCSetRegionLiveThresholdPercent, 90,</p>
<p>"Threshold for regions to be added to the collection set. "</p>
<p>"Regions with more live bytes that this will not be
collected.")</p>
<p>The "that this" should be "than this".</p>
</blockquote>
<br>
Absolutely. Fixed.<br>
<br>
Thanks,<br>
Bengt<br>
<br>
<blockquote
cite="mid:CAHjP37EOidy8g09s-RBS1EYw7XyHDHqnyQnTgee1JJTV5txDkw@mail.gmail.com"
type="cite">
<p>Cheers</p>
<p>Sent from my phone</p>
<div class="gmail_quote">On Aug 22, 2012 3:50 AM, "Bengt Rutisson"
<<a moz-do-not-send="true"
href="mailto:bengt.rutisson@oracle.com">bengt.rutisson@oracle.com</a>>
wrote:<br type="attribution">
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Hi all,<br>
<br>
Could I please have a couple of reviews for this really small
fix?<br>
<a moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Ebrutisso/7193157/webrev.00/"
target="_blank">http://cr.openjdk.java.net/~brutisso/7193157/webrev.00/</a><br>
<br>
We need to make some of the G1 develop flags available in
product builds to allow the performance team to tune G1
properly. We decided to make the flags experimental to start
with. After the performance team has evaluated the flags we
might make some of them product flags. The current prime
candidates for becoming product flags are:<br>
<br>
G1DefaultMinNewGenPercent<br>
G1DefaultMaxNewGenPercent<br>
G1OldCSetRegionLiveThresholdPercent<br>
<br>
Thanks,<br>
Bengt<br>
</blockquote>
</div>
</blockquote>
<br>
</body>
</html>