<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix"><font face="Verdana">Looks good to me</font><br>
<pre class="moz-signature" cols="72">Azeem Jiva
@javawithjiva</pre>
On 08/28/2012 12:58 PM, John Cuthbertson wrote:<br>
</div>
<blockquote cite="mid:503D06C2.6080602@oracle.com" type="cite">Hi
Everyone,
<br>
<br>
Can I have another volunteer to review the changes for this CR
(which were contributed by Brandon Mitchell at Twitter)? The
webrev can be found at:
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~johnc/7194409/webrev.0/">http://cr.openjdk.java.net/~johnc/7194409/webrev.0/</a>
<br>
<br>
Here's the description, according to Brandon:
<br>
<br>
<blockquote type="cite">os::javaTimeNanos() shows hot on
CPU_CLK_UNHALTED profiles due to
<br>
unnecessary function setup/teardown code around
<br>
Linux::supports_monotonic_clock(). I've added an inline
annotation to
<br>
simplify the funcall to a NULL check, and verified the change
using
<br>
both gdb disas and additional profiling. I observed a 2-3% CPU
time
<br>
delta in my profile data for os::javaTimeNanos().
<br>
</blockquote>
Thanks,
<br>
<br>
JohnC
<br>
</blockquote>
<br>
</body>
</html>