<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html;charset=ISO-8859-1" http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
Hi Hal,<br>
<br>
The changes look good to me.<br>
<br>
JohnC<br>
<br>
On 09/13/12 08:55, Jianhao Mo wrote:
<blockquote
cite="mid:CAKz_je43bvYHehXdZOadi7J12epkqn=FL_x4Dn0vCoc6356Kkw@mail.gmail.com"
type="cite"><font face="arial, helvetica, sans-serif">Hi all,</font>
<div><font face="arial, helvetica, sans-serif"><br>
</font></div>
<div><font face="arial, helvetica, sans-serif">Attached please find
the new patch, modified according to <span
style="color: rgb(34, 34, 34);">John's advice.</span></font></div>
<div><font face="arial, helvetica, sans-serif"><span
style="color: rgb(34, 34, 34);"><br>
</span></font></div>
<div><font face="arial, helvetica, sans-serif"><span
style="color: rgb(34, 34, 34);">Thanks </span></font><span
style="background-color: rgb(255, 255, 255); color: rgb(34, 34, 34); font-family: arial,helvetica,sans-serif;">Bengt
again for the help :)</span></div>
<div><font color="#222222" face="arial, helvetica, sans-serif"><br>
</font></div>
<div><font color="#222222" face="arial, helvetica, sans-serif">Regards,</font></div>
<div><font color="#222222" face="arial, helvetica, sans-serif"><br>
</font></div>
<div><font color="#222222" face="arial, helvetica, sans-serif">Hal<br>
</font><br>
<div class="gmail_quote">2012/9/12 Jianhao Mo <span dir="ltr"><<a
moz-do-not-send="true" href="mailto:mojianhao@gmail.com"
target="_blank">mojianhao@gmail.com</a>></span><br>
<blockquote class="gmail_quote"
style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div style="color: rgb(34, 34, 34);"><font
face="arial, helvetica, sans-serif">Hi all,</font></div>
<div style="color: rgb(34, 34, 34);"><font
face="arial, helvetica, sans-serif"><br>
</font></div>
<div style="color: rgb(34, 34, 34);"><font
face="arial, helvetica, sans-serif">Could I get a couple of reviews
for this small patch, please?</font></div>
<div style="color: rgb(80, 0, 80);">
<div><font face="arial, helvetica, sans-serif"><br>
</font></div>
<div><font face="arial, helvetica, sans-serif">7197906:
BlockOffsetArray::power_to_cards_back() needs to handle > 32 bit
shifts</font></div>
<div><font face="arial, helvetica, sans-serif"><br>
</font></div>
</div>
<div style="color: rgb(34, 34, 34);"><font
face="arial, helvetica, sans-serif">CR link:</font></div>
<div style="color: rgb(34, 34, 34);"><a moz-do-not-send="true"
href="http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7197906"
style="color: rgb(17, 85, 204);" target="_blank"><font
face="arial, helvetica, sans-serif">http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7197906</font></a></div>
<div style="color: rgb(34, 34, 34);"><font
face="arial, helvetica, sans-serif">Webrev:</font></div>
<div style="color: rgb(34, 34, 34);"><a moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Ebrutisso/7197906/webrev.01/"
style="color: rgb(17, 85, 204);" target="_blank"><font
face="arial, helvetica, sans-serif">http://cr.openjdk.java.net/~brutisso/7197906/webrev.01/</font></a></div>
<div style="color: rgb(34, 34, 34);"><span
style="color: rgb(0, 0, 0);"><font face="arial, helvetica, sans-serif">Contributed-by: </font></span></div>
<div style="color: rgb(34, 34, 34);"><font
face="arial, helvetica, sans-serif"><span style="color: rgb(0, 0, 0);">Hal
Mo <</span><a moz-do-not-send="true"
href="mailto:kungu.mjh@taobao.com" target="_blank">kungu.mjh@taobao.com</a><span
style="color: rgb(0, 0, 0);">> from Alibaba Group(with OCA) </span>
</font></div>
<div style="color: rgb(34, 34, 34);"><font
face="arial, helvetica, sans-serif"><br>
</font></div>
<div style="color: rgb(34, 34, 34);"><font
face="arial, helvetica, sans-serif">It may take a while before the CR
link is publicly accessible.</font></div>
<div style="color: rgb(34, 34, 34);"><font
face="arial, helvetica, sans-serif"><br>
</font></div>
<div style="color: rgb(34, 34, 34);"><font
face="arial, helvetica, sans-serif">In blockOffsetTable.hpp, there is
an unexpected data truncation in power_to_cards_back(uint i), which may
lead to crashing the VM on very large GC heaps.</font></div>
<div style="color: rgb(34, 34, 34);"><font
face="arial, helvetica, sans-serif">The problem could be reproduced
easily on machines, that have enough memory, with:</font></div>
<div style="color: rgb(80, 0, 80);">
<div><font face="arial, helvetica, sans-serif">$ java -Xmx135g
-XX:+UseConcMarkSweepGC</font></div>
<div><font face="arial, helvetica, sans-serif"><br>
</font></div>
</div>
<div style="color: rgb(34, 34, 34);"><font
face="arial, helvetica, sans-serif">The proposed patch fixes this
problem, and builds on all OpenJDK supported platforms.</font></div>
<div style="color: rgb(34, 34, 34);"><font
face="arial, helvetica, sans-serif"><br>
</font></div>
<div style="color: rgb(34, 34, 34);"><font
face="arial, helvetica, sans-serif">I'd like to thank Bengt Rutisson
for the initial review and help preparing the CR and Webrev.</font></div>
<div style="color: rgb(34, 34, 34);"><font
face="arial, helvetica, sans-serif"><br>
</font></div>
<font face="arial, helvetica, sans-serif">Regards,<br>
Hal</font>
</blockquote>
</div>
<br>
</div>
</blockquote>
<br>
</body>
</html>