<br>Thanks Bengt; changes look good to me too, Hal, although i just looked at the changes, and did not<br>check the code to see if there might be more instances of the fingered anti-pattern. (I am pretty sure<br>you and John and other reviewers have covered that front well :-)<br>
<br>Bengt, any chance that the fix will get bkported also to 7uXX soon, for some suitable value of XX?<br><br>thanks!<br>-- ramki<br><br><div class="gmail_quote">On Thu, Sep 13, 2012 at 8:27 PM, Bengt Rutisson <span dir="ltr"><<a href="mailto:bengt.rutisson@oracle.com" target="_blank">bengt.rutisson@oracle.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000">
<div><br>
Hi Ramki,<br>
<br>
Thanks for looking at this!<br>
<br>
Here's a webrev based on the second patch that Hal sent out:<br>
<a href="http://cr.openjdk.java.net/%7Ebrutisso/7197906/webrev.02/" target="_blank">http://cr.openjdk.java.net/~brutisso/7197906/webrev.02/</a><span class="HOEnZb"><font color="#888888"><br>
<br>
Bengt</font></span><div><div class="h5"><br>
<br>
On 2012-09-13 18:12, Srinivas Ramakrishna wrote:<br>
</div></div></div><div><div class="h5">
<blockquote type="cite">Hal, thanks for the catch and the fix!<br>
<br>
Bengt, might it be possible to host this as a traditional webrev
in the usual place, to simplify review logistics?<br>
<br>
thanks!<br>
-- ramki<br>
<br>
<div class="gmail_quote">On Thu, Sep 13, 2012 at 4:55 PM, Jianhao
Mo <span dir="ltr"><<a href="mailto:mojianhao@gmail.com" target="_blank">mojianhao@gmail.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><font face="arial, helvetica, sans-serif">Hi all,</font>
<div><font face="arial, helvetica, sans-serif"><br>
</font></div>
<div><font face="arial, helvetica, sans-serif">Attached please
find the new patch, modified according to <span style="color:rgb(34,34,34)">John's advice.</span></font></div>
<div><font face="arial, helvetica, sans-serif"><span style="color:rgb(34,34,34)"><br>
</span></font></div>
<div><font face="arial, helvetica, sans-serif"><span style="color:rgb(34,34,34)">Thanks </span></font><span style="color:rgb(34,34,34);font-family:arial,helvetica,sans-serif">Bengt
again for the help :)</span></div>
<div><font color="#222222" face="arial, helvetica, sans-serif"><br>
</font></div>
<div><font color="#222222" face="arial, helvetica, sans-serif">Regards,</font></div>
<div><font color="#222222" face="arial, helvetica, sans-serif"><br>
</font></div>
<div><font color="#222222" face="arial, helvetica, sans-serif">Hal<br>
</font>
<div>
<div><br>
<div class="gmail_quote">2012/9/12 Jianhao Mo <span dir="ltr"><<a href="mailto:mojianhao@gmail.com" target="_blank">mojianhao@gmail.com</a>></span><br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div style="color:rgb(34,34,34)"><font face="arial,
helvetica, sans-serif">Hi all,</font></div>
<div style="color:rgb(34,34,34)"><font face="arial,
helvetica, sans-serif"><br>
</font></div>
<div style="color:rgb(34,34,34)"><font face="arial,
helvetica, sans-serif">Could I get a couple of
reviews for this small patch, please?</font></div>
<div style="color:rgb(80,0,80)">
<div><font face="arial, helvetica, sans-serif"><br>
</font></div>
<div><font face="arial, helvetica, sans-serif">7197906:
BlockOffsetArray::power_to_cards_back() needs
to handle > 32 bit shifts</font></div>
<div><font face="arial, helvetica, sans-serif"><br>
</font></div>
</div>
<div style="color:rgb(34,34,34)"><font face="arial,
helvetica, sans-serif">CR link:</font></div>
<div style="color:rgb(34,34,34)"><a href="http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7197906" style="color:rgb(17,85,204)" target="_blank"><font face="arial, helvetica, sans-serif">http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7197906</font></a></div>
<div style="color:rgb(34,34,34)"><font face="arial,
helvetica, sans-serif">Webrev:</font></div>
<div style="color:rgb(34,34,34)"><a href="http://cr.openjdk.java.net/%7Ebrutisso/7197906/webrev.01/" style="color:rgb(17,85,204)" target="_blank"><font face="arial, helvetica, sans-serif">http://cr.openjdk.java.net/~brutisso/7197906/webrev.01/</font></a></div>
<div style="color:rgb(34,34,34)"><span style="color:rgb(0,0,0)"><font face="arial,
helvetica, sans-serif">Contributed-by: </font></span></div>
<div style="color:rgb(34,34,34)">
<font face="arial, helvetica, sans-serif"><span style="color:rgb(0,0,0)">Hal Mo <</span><a href="mailto:kungu.mjh@taobao.com" target="_blank">kungu.mjh@taobao.com</a><span style="color:rgb(0,0,0)">> from Alibaba
Group(with OCA) </span>
</font></div>
<div style="color:rgb(34,34,34)"><font face="arial,
helvetica, sans-serif"><br>
</font></div>
<div style="color:rgb(34,34,34)"><font face="arial,
helvetica, sans-serif">It may take a while
before the CR link is publicly accessible.</font></div>
<div style="color:rgb(34,34,34)"><font face="arial,
helvetica, sans-serif"><br>
</font></div>
<div style="color:rgb(34,34,34)"><font face="arial,
helvetica, sans-serif">In blockOffsetTable.hpp,
there is an unexpected data truncation in
power_to_cards_back(uint i), which may lead to
crashing the VM on very large GC heaps.</font></div>
<div style="color:rgb(34,34,34)"><font face="arial,
helvetica, sans-serif">The problem could be
reproduced easily on machines, that have enough
memory, with:</font></div>
<div style="color:rgb(80,0,80)">
<div><font face="arial, helvetica, sans-serif">$
java -Xmx135g -XX:+UseConcMarkSweepGC</font></div>
<div><font face="arial, helvetica, sans-serif"><br>
</font></div>
</div>
<div style="color:rgb(34,34,34)">
<font face="arial, helvetica, sans-serif">The
proposed patch fixes this problem, and builds on
all OpenJDK supported platforms.</font></div>
<div style="color:rgb(34,34,34)"><font face="arial,
helvetica, sans-serif"><br>
</font></div>
<div style="color:rgb(34,34,34)"><font face="arial,
helvetica, sans-serif">I'd like to thank Bengt
Rutisson for the initial review and help
preparing the CR and Webrev.</font></div>
<div style="color:rgb(34,34,34)"><font face="arial,
helvetica, sans-serif"><br>
</font></div>
<font face="arial, helvetica, sans-serif">Regards,<br>
Hal</font>
</blockquote>
</div>
<br>
</div>
</div>
</div>
</blockquote>
</div>
<br>
</blockquote>
<br>
</div></div></div>
</blockquote></div><br>