<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html;charset=ISO-8859-1" http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
Hi Vitaly,<br>
<br>
Good catch - and you are correct. Changed.<br>
<br>
JohnC<br>
<br>
On 10/02/12 17:33, Vitaly Davidovich wrote:
<blockquote
cite="mid:CAHjP37E4p8oohsC1LULeE7AdiOra1jHVbqWTy68OBR=sWJ22XA@mail.gmail.com"
type="cite">
<p dir="ltr">Hi John,</p>
<p dir="ltr">concurrentMark.cpp:</p>
<p dir="ltr">4118 if (_cm->verbose_low()) {<br>
4119 gclog_or_tty->print_cr("[%d] starting termination
protocol", _worker_id);<br>
4120 }</p>
<p dir="ltr">Should be %u format? Same in
g1OopClosuresg1OopClosures.inline.hpp:<br>
if (_cm->verbose_high()) {<br>
114 gclog_or_tty->print_cr("[%d] we're looking at location "<br>
115 "*"PTR_FORMAT" = "PTR_FORMAT,<br>
116 _task->worker_id(), p, (void*) obj);<br>
117 }</p>
<p dir="ltr">Thanks</p>
<p dir="ltr">Sent from my phone</p>
<div class="gmail_quote">On Oct 2, 2012 5:54 PM, "John Cuthbertson"
<<a moz-do-not-send="true" href="mailto:john.cuthbertson@oracle.com">john.cuthbertson@oracle.com</a>>
wrote:<br type="attribution">
<blockquote class="gmail_quote"
style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">Hi
Everyone,<br>
<br>
Can I have another couple of volunteers review the changes for this CR
- the webrev can be found at: <a moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Ejohnc/7127708/webrev.0/"
target="_blank">http://cr.openjdk.java.net/~johnc/7127708/webrev.0/</a><br>
<br>
Summary:<br>
Exactly what it says the the CR's description:<br>
<blockquote class="gmail_quote"
style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
In G1's concurrent mark files we use an int for the task ID and call it
"task num". Recent work done by Jon Masamitsu:<br>
<br>
7121618: Change type of number of GC workers to unsigned int<br>
<br>
has replaced int's with uint's for the worker IDs across our GCs. We
should also make the necessary changes in the G1 files to further
conform to that. While we're at it we should also rename "task num" as
"worker id" to be consistent with the rest of the GCs.<br>
</blockquote>
<br>
<br>
The changes were contributed by Kaushik Srenevasan from Twitter. I've
looked them over and they look OK to me.<br>
<br>
Testing: jtreg tests and specjvm (Kaushik); GC test suite with a low
IHOP and marking verification (JohnC); a jprt test run is in the queue.<br>
<br>
Thanks,<br>
<br>
JohnC<br>
<br>
</blockquote>
</div>
</blockquote>
<br>
</body>
</html>