<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div>Hey Bengt,</div><div><br></div><div>Code review looks simple enough.</div><div><br></div><div>One nit on naming consistency:</div><div>Should "<span class="Apple-style-span" style="color: rgb(0, 0, 255); font-family: monospace; font-weight: bold; white-space: pre; ">CMSIncrementalMode</span>" be "<span class="Apple-style-span" style="color: rgb(0, 0, 255); font-family: monospace; font-weight: bold; white-space: pre; ">UseCMSIncrementalGC</span>"</div><div>to be consistent with other flags?</div><div><br></div><div>A couple more general questions:</div><div><br></div><div>What GC combinations are non-deprecated and what are their</div><div>intended use cases?</div><div><br></div><div>For example, what GC combinations are intended for the following?:</div><div>* 4-100GB Heap (e.g. 64bit); High Priority: 200ms max pause due to GC; Env: >50% Heap long lived (>12hour)</div><div>* 4-100GB Heap (e.g. 64bit); High Priority: 500ms max pause due to GC; Env: ~40% Heap short lived (<1minute) & ~40% Heap long lived (>12hour)</div><div>* 1-3.5GB Heap (e.g. 32bit); High Priority: 200ms max pause due to GC; Env: ~90% Heap short lived (<1minute)</div><div>* 100-1024MB Heap (e.g. 32bit/embedded); High Priority: 500ms max pause due to GC; Env: varying short/long lived data profiles over time</div><div><br></div><div>Thanks,</div><div>Joel.</div><div><br></div>Date: Wed, 19 Dec 2012 13:40:18 +0100<br>From: Bengt Rutisson <<a href="mailto:bengt.rutisson@oracle.com">bengt.rutisson@oracle.com</a>><br>Subject: Request for review (XS): 8003822: Deprecate the incremental<br><span class="Apple-tab-span" style="white-space: pre; "> </span>mode<span class="Apple-tab-span" style="white-space: pre; "> </span>of CMS<br>To: <a href="mailto:hotspot-gc-dev@openjdk.java.net">hotspot-gc-dev@openjdk.java.net</a><br>Message-ID: <<a href="mailto:50D1B5B2.4010709@oracle.com">50D1B5B2.4010709@oracle.com</a>><br>Content-Type: text/plain; charset=ISO-8859-1; format=flowed<br><br><br>Hi all,<br><br>Can I have a couple of reviews for this change to deprecate iCMS?<br><br><a href="http://cr.openjdk.java.net/~brutisso/8003822/webrev.00/">http://cr.openjdk.java.net/~brutisso/8003822/webrev.00/</a><br><br>This is part of the work for JEP 173:<br><br>JEP 173: Retire Some Rarely-Used GC Combinations<br><a href="http://openjdk.java.net/jeps/173">http://openjdk.java.net/jeps/173</a><br><br>The webrev is based on the the earlier webrev that I sent out to <br>deprecate the DefNew + CMS and ParNew + SerialOld GC combinations:<br><br><a href="http://cr.openjdk.java.net/~brutisso/8003820/webrev.00/">http://cr.openjdk.java.net/~brutisso/8003820/webrev.00/</a><br><br>Thanks,<br>Bengt<br></body></html>