<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix"><br>
Hi Ramki,<br>
<br>
Thanks for looking at this!<br>
<br>
On 12/20/12 1:59 AM, Srinivas Ramakrishna wrote:<br>
</div>
<blockquote
cite="mid:CABzyjymv_Exx=wMv+xCHC6uz3nXphaf=yXJzKfBJ-=6x+mKkRg@mail.gmail.com"
type="cite">Hi Bengt --<br>
<br>
Looks fine (although -- and this not part of the CR --
Arguments::parse() seems to have grown rather large and wants to<br>
be refactored into a few distinct pieces -- perhaps by "functional
module"; but that's another bug).<br>
</blockquote>
<br>
You are absolutely right. We need to clean Arguments::parse() up,
but we should not do it as part of this fix. :)<br>
<br>
<blockquote
cite="mid:CABzyjymv_Exx=wMv+xCHC6uz3nXphaf=yXJzKfBJ-=6x+mKkRg@mail.gmail.com"
type="cite">
What happens when you run CMS on a single-processor. I hope you
don't see a deprecation warning.<br>
</blockquote>
<br>
Ooops. Good point. It took me a long while to find a machine with
just one cpu that could actually run JDK8. But you are correct. We
will print a warning in that case.<br>
<br>
I think the fix is to not pick DefNew by default for single
processor machines. I'll see if I can get any performance data for
that.<br>
<br>
Thanks,<br>
Bengt<br>
<br>
<blockquote
cite="mid:CABzyjymv_Exx=wMv+xCHC6uz3nXphaf=yXJzKfBJ-=6x+mKkRg@mail.gmail.com"
type="cite"><br>
-- ramki<br>
<br>
<br>
<div class="gmail_quote">On Tue, Dec 18, 2012 at 6:02 AM, Bengt
Rutisson <span dir="ltr"><<a moz-do-not-send="true"
href="mailto:bengt.rutisson@oracle.com" target="_blank">bengt.rutisson@oracle.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000"> <br>
Hi all,<br>
<br>
Can I have a couple of reviews for this change to deprecate
the DefNew + CMS and ParNew + SerialOld GC combinations?<br>
<br>
<a moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Ebrutisso/8003820/webrev.00/"
target="_blank">http://cr.openjdk.java.net/~brutisso/8003820/webrev.00/</a><br>
<br>
<br>
This is part of the work for JEP 173:<br>
<br>
JEP 173: Retire Some Rarely-Used GC Combinations<br>
<a moz-do-not-send="true"
href="http://openjdk.java.net/jeps/173" target="_blank">http://openjdk.java.net/jeps/173</a><br>
<br>
The work is tracked in this bug:<br>
<br>
8003820 : Deprecate untested and rarely used GC combinations<br>
<a moz-do-not-send="true"
href="http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8003820"
target="_blank">http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8003820</a><br>
<br>
Thanks,<br>
Bengt<br>
</div>
</blockquote>
</div>
<br>
</blockquote>
<br>
</body>
</html>