<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix"><br>
Hi again John,<br>
<br>
I realized that I was a bit too fast with my comment about using
ObsoleteFlag. Your code is aliasing the old names for the new ones
which is something the obsolete flag management does not do.<br>
<br>
But on the other hand, do we really want to do this? These are all
experimental flags and we are pushing this change to a major
release, JDK8. Personally I don't think it is worth supporting the
old names.<br>
<br>
Bengt<br>
<br>
On 12/20/12 5:45 AM, Bengt Rutisson wrote:<br>
</div>
<blockquote cite="mid:50D297F5.8060607@oracle.com" type="cite">
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
<div class="moz-cite-prefix"><br>
Hi John,<br>
<br>
This looks good. But I think that instead of your change in
<meta http-equiv="content-type" content="text/html;
charset=UTF-8">
arguments.cpp you could make use of the obsolete_jvm_flags list
that exist in the same file. I think that is intended for
exactly this purpose. Accepting a removed flag name for a little
while. The nice thing about it it that you specify how long you
will accept the old name.<br>
<br>
static ObsoleteFlag obsolete_jvm_flags[] = {<br>
{ "UseTrainGC", JDK_Version::jdk(5),
JDK_Version::jdk(7) },<br>
<br>
If you use this you also have to remove the old flag names from
globals.hpp.<br>
<br>
Bengt<br>
<br>
<br>
On 12/20/12 1:56 AM, John Cuthbertson wrote:<br>
</div>
<blockquote cite="mid:50D26242.6060704@oracle.com" type="cite">Hi
Everyone, <br>
<br>
Some flag name changes suggested by the JVM performance team
based upon feedback they have received. The webrev can found at:
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Ejohnc/8001424/webrev.0/">http://cr.openjdk.java.net/~johnc/8001424/webrev.0/</a>
<br>
<br>
Basically the changes are those listed in the webrev: <br>
<br>
G1DefaultMinNewGenPercent is being replaced by G1NewSizePercent
<br>
G1DefaultMaxNewGenPercent is being replaced by
G1MaxNewSizePercent <br>
G1OldCSetRegionLiveThresholdPercent is being replaced by
G1MixedGCLiveThresholdPercent <br>
<br>
Thanks, <br>
<br>
JohnC <br>
</blockquote>
<br>
</blockquote>
<br>
</body>
</html>