<html>
<head>
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
Forwarding to the GC dev list.<br>
<br>
JohnC<br>
<div class="moz-forward-container"><br>
-------- Original Message --------
<table class="moz-email-headers-table" border="0" cellpadding="0"
cellspacing="0">
<tbody>
<tr>
<th nowrap="nowrap" valign="BASELINE" align="RIGHT">Subject:
</th>
<td>Fwd: Re: Request for review: 8004132 SerialGC
ValidateMarkSweep code broken</td>
</tr>
<tr>
<th nowrap="nowrap" valign="BASELINE" align="RIGHT">Date: </th>
<td>Thu, 20 Dec 2012 14:19:24 -0800</td>
</tr>
<tr>
<th nowrap="nowrap" valign="BASELINE" align="RIGHT">From: </th>
<td>Tao Mao <a class="moz-txt-link-rfc2396E" href="mailto:tao.mao@oracle.com"><tao.mao@oracle.com></a></td>
</tr>
<tr>
<th nowrap="nowrap" valign="BASELINE" align="RIGHT">Organization:
</th>
<td>Oracle Corporation</td>
</tr>
<tr>
<th nowrap="nowrap" valign="BASELINE" align="RIGHT">To: </th>
<td><a class="moz-txt-link-abbreviated" href="mailto:hotspot-dev@openjdk.java.net">hotspot-dev@openjdk.java.net</a>
<a class="moz-txt-link-rfc2396E" href="mailto:hotspot-dev@openjdk.java.net"><hotspot-dev@openjdk.java.net></a></td>
</tr>
</tbody>
</table>
<br>
<br>
<pre>Hi hotspot-dev,
Is there anyone interested in reviewing the change?
Thanks.
Tao
-------- Original Message --------
Subject: Re: Request for review: 8004132 SerialGC ValidateMarkSweep
code broken
Date: Mon, 17 Dec 2012 13:02:15 -0800
From: Tao Mao <a class="moz-txt-link-rfc2396E" href="mailto:tao.mao@oracle.com"><tao.mao@oracle.com></a>
Organization: Oracle Corporation
To: John Cuthbertson <a class="moz-txt-link-rfc2396E" href="mailto:john.cuthbertson@oracle.com"><john.cuthbertson@oracle.com></a>
CC: hotspot-gc-dev openjdk.java.net <a class="moz-txt-link-rfc2396E" href="mailto:hotspot-gc-dev@openjdk.java.net"><hotspot-gc-dev@openjdk.java.net></a>
Thank you, John. A new webrev is uploaded as you advised.
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~tamao/8004132/webrev.01/">http://cr.openjdk.java.net/~tamao/8004132/webrev.01/</a>
I would like to have one more review if possible.
Thanks.
Tao
On 12/13/2012 4:05 PM, John Cuthbertson wrote:
> Hi Tao,
>
> This looks good to me. One comment - the functionality of
> RecordMarkSweepCompaction depends upon ValidateMarkSweep you might
> want to remove this flag as well.
>
> JohnC
>
> On 12/04/12 15:47, Tao Mao wrote:
>> 8004132 : SerialGC: ValidateMarkSweep broken when running GCOld
>> <a class="moz-txt-link-freetext" href="http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8004132">http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8004132</a>
>>
>> <a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~tamao/8004132/webrev.00/">http://cr.openjdk.java.net/~tamao/8004132/webrev.00/</a>
>>
>> Passed JPRT; I checked ValidateMarkSweep can't be triggered now with
>> the fix.
>>
>> Background:
>>
>> While verifying the functionality of the ValidateMarkSweep code with
>> the Serial collector (prior to adding code to enable this feature in
>> G1) Tao and myself saw various crashes and failures when running GC Old.
>>
>> Script to run GCOld:
>> #JHOME=/export/jdk8/solaris-x64
>> #JHOME=/java/re/jdk/6/promoted/latest/binaries/solaris-i586/fastdebug
>> JHOME=/export/bugs/8001047/jdk7/solaris-x64
>>
>> $JHOME/bin/java -server -Xms1g -Xmx1g \
>> -XX:+UseSerialGC \
>> -XX:+ValidateMarkSweep \
>> -XX:+PrintGCDetails -XX:+PrintGCTimeStamps
>> -XX:+ShowMessageBoxOnError \
>> GCOld 9000 20 5 30 500000
>>
>> Note the ValidateMarkSweep functionality is only available in
>> non-product builds.
>>
>> This seems to have been broken for a long while - we even saw the
>> crash with jdk6. Thus we suggest to remove the ValidateMarkSweep code.
>>
>
</pre>
<br>
</div>
<br>
</body>
</html>