<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
Hi Bengt,<br>
<br>
Excellent. Ship it.<br>
<br>
JohnC<br>
<br>
<div class="moz-cite-prefix">On 1/16/2013 4:01 AM, Bengt Rutisson
wrote:<br>
</div>
<blockquote cite="mid:50F69694.30309@oracle.com" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
<div class="moz-cite-prefix"><br>
Hi John,<br>
<br>
Thanks for the review!<br>
<br>
On 1/15/13 6:59 PM, John Cuthbertson wrote:<br>
</div>
<blockquote cite="mid:50F59910.2010000@oracle.com" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
Hi Bengt,<br>
<br>
Changes look good to me. Minor nits:<br>
<br>
Copyrights need updating.<br>
</blockquote>
<br>
I'll leave the copyright year as is for now. There is an ongoing
discussion about whether or not we need to do this. I'd prefer to
wait and see what the decision is.<br>
<br>
<blockquote cite="mid:50F59910.2010000@oracle.com" type="cite">
Use UINT32_FORMAT instead of %d in the error message.<br>
</blockquote>
<br>
Done.<br>
<br>
<blockquote cite="mid:50F59910.2010000@oracle.com" type="cite">
Check the indentation of the for loop in
G1GCPhaseTimes::note_gc_end().<br>
</blockquote>
<br>
Done.<br>
<br>
Bengt<br>
<br>
<blockquote cite="mid:50F59910.2010000@oracle.com" type="cite"> <br>
JohnC<br>
<br>
<div class="moz-cite-prefix">On 1/14/2013 1:06 PM, Bengt
Rutisson wrote:<br>
</div>
<blockquote cite="mid:50F47361.7020306@oracle.com" type="cite">
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
<br>
Hi all,<br>
<br>
Could I have a couple of reviews for this small change?<br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Ebrutisso/8006242/webrev.00/">http://cr.openjdk.java.net/~brutisso/8006242/webrev.00/</a><br>
<br>
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
Thanks to John Cuthbertson for finding this bug and providing
excellent data to track down the issue.<br>
<br>
From the bug report:<br>
<br>
In non-product builds the WorkerDataArrays in G1 are
initialized to -1 in WorkerDataArray<T>::reset() when a
GC starts. At the end of a GC
WorkerDataArray<T>::verify() verifies that all entries
in a WorkerDataArray has been set. Currently it does this by
asserting that the entries are >= 0. This is fine in theory
since the entries should contain counts or times that are all
positive.<br>
<br>
The problem is that some WorkerDataArrays are of type double.
And some of those are set up through calculations using
doubles. If those calculations result in a value close to 0 we
could end up with a value slightly less than 0 since double
calculations don't have full precision.<br>
<br>
All we really want to verify is that all the entries were set.
So, it should be enough to verify that entries do not contain
the value set by the reset() method. <br>
<br>
Bengt<br>
</blockquote>
<br>
</blockquote>
<br>
</blockquote>
<br>
</body>
</html>