<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<tt>Also, the jstat man page needs to be updated per this change (</tt><tt>I
mentioned <br>
this in the previous review [1])</tt><tt><br>
</tt><br>
<tt> <a class="moz-txt-link-freetext"
href="http://download.java.net/jdk8/docs/technotes/tools/share/jstat.html">http://download.java.net/jdk8/docs/technotes/tools/share/jstat.html</a><br>
<br>
You can contact the docs team for this.</tt><tt><br>
Mandy<br>
[1]
<a class="moz-txt-link-freetext" href="http://mail.openjdk.java.net/pipermail/serviceability-dev/2013-January/007957.html">http://mail.openjdk.java.net/pipermail/serviceability-dev/2013-January/007957.html</a><br>
</tt><br>
On 2/5/13 12:14 PM, Mandy Chung wrote:
<blockquote cite="mid:51116827.80100@oracle.com" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
<tt>Hi Erik,<br>
<br>
On 2/4/13 8:01 AM, Erik Helin wrote:</tt>
<blockquote type="cite">
<pre style="white-space: pre-wrap">There have been some updates to the hotspot code based on feedback from
the hotspot-gc-dev mailing list. The only change to the JDK code is that
the namespace is back to "sun.gc" :)
New webrevs:
- jdk: <a moz-do-not-send="true" href="http://cr.openjdk.java.net/%7Eehelin/8004172/jdk/webrev.03/">http://cr.openjdk.java.net/~ehelin/8004172/jdk/webrev.03/</a>
- hotspot: <a moz-do-not-send="true" href="http://cr.openjdk.java.net/%7Eehelin/8004172/hotspot/webrev.03/">http://cr.openjdk.java.net/~ehelin/8004172/hotspot/webrev.03/</a>
</pre>
</blockquote>
<tt>Looks good. Minor nits:<br>
<br>
gcCapacityOutput1.awk</tt> <tt>- should the last column in L7
be removed?</tt><br>
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
<pre>jstatGcMetaCapacityOutput1.sh - it's a new test and the copyright year should be 2013.
<blockquote type="cite"><pre>Note that the fixed tests will continue to fail until the HotSpot
part of the change finds it way into the tl forest.</pre></blockquote>
How are you going to integrate the hotspot and jdk fixes in a
synchronized fashion? We shall make sure the TL sun/tools/jstat
tests pass at all times.
Mandy
</pre>
</blockquote>
<br>
</body>
</html>