<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
PS1:<br>
Jesper, how did you check and make sure that modified flags are
treated properly at all their occurrences? (So I can apply
generally. For the review, I manually checked all of their
occurrences).<br>
<br>
<br>
<br>
PS2:<br>
product(intx, SurvivorRatio,
8, \<br>
"Ratio of eden/survivor space
size") \<br>
\<br>
product(intx, NewRatio,
2, \<br>
"Ratio of new/old generation
sizes") \<br>
<br>
For clarity and consistency with SurvivorRatio definition, the
NewRatio definition above should be reversed as "Ratio of <b>old/new</b>
generation sizes"<br>
<br>
What are your opinions? If you favor my suggestion, I'll go ahead
creating a CR and modify it, since it's a fairly busy VM option.<br>
<br>
Thank you.<br>
Tao<br>
<br>
<br>
On 2/5/2013 3:41 PM, Tao Mao wrote:
<blockquote cite="mid:5111988E.30104@oracle.com" type="cite">Looks
good to me. I've manually checked all occurrences of the four
flags. They are treated properly after the change. <br>
I'm not an official reviewer. But, as I understand, code review
needs at least one official reviewer. So, push it! <br>
<br>
Thanks. <br>
Tao <br>
<br>
On 1/25/2013 8:24 AM, Jesper Wilhelmsson wrote: <br>
<blockquote type="cite">Hi John, <br>
<br>
Thanks for the review! <br>
I have removed G1InitYoungSurvRatio and updated the webrev and
the bug to reflect this. <br>
/Jesper <br>
<br>
<br>
On 2013-01-25 01:27, John Cuthbertson wrote: <br>
<blockquote type="cite">Hi Jesper, <br>
<br>
Looks good to me. <br>
<br>
Can you also remove the unused G1InitYoungSurvRatio from
g1_globals.hpp? <br>
<br>
Thanks, <br>
<br>
JohnC <br>
<br>
On 1/24/2013 1:45 PM, Jesper Wilhelmsson wrote: <br>
<blockquote type="cite">Hi, <br>
<br>
I'm looking for a couple of reviews for this small change. <br>
<br>
Bug: JDK-8006432 - Ratio flags should be unsigned <br>
<br>
Webrev: <br>
<a class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Ejwilhelm/8006432/webrev/">http://cr.openjdk.java.net/~jwilhelm/8006432/webrev/</a>
<br>
<br>
Summary: <br>
Four flags whose contents are assumed to be unsigned were
stored in signed <br>
variables. I have changed these to be unsigned instead. <br>
<br>
Testing: <br>
Manual testing and JPRT. <br>
<br>
/Jesper <br>
</blockquote>
<br>
</blockquote>
</blockquote>
</blockquote>
</body>
</html>