<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
Hi Everyone,<br>
<br>
I meant to add:<br>
<br>
Apologies to Tao for not considering this case during the original
review and<b> many, many</b> thanks to Bengt for doing the initial
analysis, diagnosis, and suggesting a fix.<br>
<br>
JohnC<br>
<br>
<div class="moz-cite-prefix">On 2/11/2013 10:01 AM, John Cuthbertson
wrote:<br>
</div>
<blockquote cite="mid:51193206.3090001@oracle.com" type="cite">Hi
Everyone,
<br>
<br>
Can I get a couple of reviews of this fix - the webrev can be
found at: <a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~johnc/8007772/webrev.0/">http://cr.openjdk.java.net/~johnc/8007772/webrev.0/</a>
<br>
<br>
Summary:
<br>
An assert I asked Tao to add during his recent scanning
optimization for Humongous regions was failing. The reason was
because the local marking task could have been signaled to abort
(because it exceeded it's time interval) while scanning the
humongous object. In this case we would restart the marking step
with a memory region with a slightly different starting address
causing the assert to trip. Without the assert this would nullify
Tao change and cause further unnecessary scanning of (a subset of)
the humongous object. We should be giving up the current humongous
region even if the task is asked to abort.
<br>
<br>
Testing:
<br>
The failing tests from nsk.stress and vm.gc nightly tests.
<br>
<br>
Without fix:
<br>
TOTAL TESTS IN RUN: 154
<br>
TEST PASS: 102; 66% rate
<br>
TEST FAIL: 52; 33% rate
<br>
TEST UNDEFINED: 0; 0% rate
<br>
TEST INCOMPLETE: 0; 0% rate
<br>
TESTS NOT RUN: 0
<br>
<br>
With fix:
<br>
TOTAL TESTS IN RUN: 154
<br>
TEST PASS: 153; 99% rate
<br>
TEST FAIL: 1; 0% rate
<br>
TEST UNDEFINED: 0; 0% rate
<br>
TEST INCOMPLETE: 0; 0% rate
<br>
TESTS NOT RUN: 0
<br>
<br>
The remaining failure is FinalizerTest03 - a known failure.
<br>
<br>
Thanks,
<br>
<br>
JohnC
<br>
<br>
</blockquote>
<br>
</body>
</html>