<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
Hi Bengt, Leonid,<br>
<br>
On 2/14/2013 4:47 AM, Bengt Rutisson wrote:<br>
<blockquote cite="mid:511CDCE1.6070009@oracle.com" type="cite">
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
<div class="moz-cite-prefix"><br>
Leonid,<br>
<br>
</div>
Yes, this is an interesting problem. If the buffer for the
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
OutputAnalyzer gets full before the jmap call returns we will have
a deadlock.<br>
<br>
Would you suggest that the test should spawn two processes? How do
they do the handshaking to find out when it is safe to do a jmap
call from one to the other? <br>
</blockquote>
<br>
As Mikael Gerdin has pointed out there are already a bunch of NMT
regression tests that call jcmd on themselves and I just followed
the guidelines given in Christian Tornqvist's wiki. If this is an
issue then all of these NMT tests should be removed and this
mechanism should also be removed.<br>
<br>
Also the output of the jcmd is not that important - it's the fact
that the test didn't crash. So if there's a way avoid the potential
deadlock by disregarding the output - so be it.<br>
<br>
<blockquote cite="mid:511CDCE1.6070009@oracle.com" type="cite"> <br>
Looking at this test again reminded me of a few more minor things:<br>
<br>
* It would be good if the test had the "@key gc" tag that I am
just about to add. See:<br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Ebrutisso/8006398/webrev.01/">http://cr.openjdk.java.net/~brutisso/8006398/webrev.01/</a><br>
</blockquote>
<br>
OK. Sure.<br>
<br>
<blockquote cite="mid:511CDCE1.6070009@oracle.com" type="cite"> <br>
* You don't need -XX:+IgnoreUnrecognizedVMOptions in the @run
command<br>
</blockquote>
<br>
Why not? What about running on a platform where UseG1GC is not
currently supported and the flag gives an error?<br>
<br>
<blockquote cite="mid:511CDCE1.6070009@oracle.com" type="cite"> <br>
* The test is in a directory called 8005875/. I again think this
is obsolete if we use the @bug tag. I would prefer to name the
folder something meaningful.<br>
</blockquote>
<br>
OK. But IMO the bug ID is meaningful. Is it any more meaningful than
TestJcmdG1AndZeroPGCT? I'm not sure. Suggest a name that you find
more meaningful.<br>
<br>
JohnC<br>
</body>
</html>