<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 2/14/13 8:27 AM, Bengt Rutisson
wrote:<br>
</div>
<blockquote cite="mid:511C91DF.20106@oracle.com" type="cite">
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
<div class="moz-cite-prefix"><br>
Hi John,<br>
<br>
Nice test!<br>
<br>
Using the testlibrary really makes these test readable!<br>
<br>
A couple of minor comments:<br>
<br>
Since ProcessBuilder.command() takes variable number of String
arguments, you don't have to create a String[] yourself. You can
let the JDK do that for you. So, this line:<br>
<br>
pb.command(new String[] { JDKToolFinder.getJDKTool("jcmd"),
pid, "Thread.print"}); <br>
<br>
Could be simplified to:<br>
<br>
pb.command(JDKToolFinder.getJDKTool("jcmd"), pid,
"Thread.print"); <br>
<br>
<br>
Also, you call the test Test8005875. I think this is what we
used to do. But I have been told that it is better to use the
@bug tag to indicate the bug number and call the test something
meaningful. I like this much better since if the test fails you
can actually get a clue of what is going wrong.<br>
<br>
And I think you should give a name to the @name tag'<br>
</div>
</blockquote>
<br>
I mean the @test tag. :)<br>
<br>
<blockquote cite="mid:511C91DF.20106@oracle.com" type="cite">
<div class="moz-cite-prefix"> <br>
So I would prefer something like:<br>
<br>
/* @test TestG1JcmdThreadPrint<br>
* @bug 8005875<br>
* @summary Use jcmd to generate a thread dump of a Java program
being run with G1 and PGCT=0 to verify 8005875<br>
* @library /testlibrary<br>
* @run main/othervm -XX:+UseG1GC -XX:ParallelGCThreads=0
-XX:+IgnoreUnrecognizedVMOptions TestG1JcmdThreadPrint<br>
*/<br>
<br>
import com.oracle.java.testlibrary.*;<br>
<br>
<meta http-equiv="content-type" content="text/html;
charset=UTF-8">
public class TestG1JcmdThreadPrint {<br>
...<br>
<br>
<br>
Thanks,<br>
Bengt<br>
On 2/14/13 1:51 AM, John Cuthbertson wrote:<br>
</div>
<blockquote cite="mid:511C352F.5030606@oracle.com" type="cite">Hi
Everyone, <br>
<br>
Can I have a couple of volunteers review the regression test for
8005875 - the webrev can be found at: <a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Ejohnc/8008188/webrev.0/">http://cr.openjdk.java.net/~johnc/8008188/webrev.0/</a>
<br>
<br>
The test is very simple and issues "jcmd <pid>
Thread.print" against itself. With G1 and PGCT=0, and before the
fix for 8005875, this command crashes the VM. <br>
<br>
Testing: <br>
jdk8 build (b76) with fix for 8005875; jdk8 build (b71) without
fix for 8005875; Changed the test options to run the test with
the invalid flag -XX:+UseG2GC. <br>
<br>
Thanks, <br>
<br>
JohnC <br>
</blockquote>
<br>
</blockquote>
<br>
</body>
</html>