<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
Hi Bengt,<br>
<br>
Thanks for looking at the test. <br>
<br>
<div class="moz-cite-prefix">On 2/13/2013 11:27 PM, Bengt Rutisson
wrote:<br>
</div>
<blockquote cite="mid:511C91DF.20106@oracle.com" type="cite">
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
<div class="moz-cite-prefix"><br>
Hi John,<br>
<br>
Nice test!<br>
<br>
Using the testlibrary really makes these test readable!<br>
</div>
</blockquote>
<br>
Agree. Makes life a lot easier.<br>
<br>
<blockquote cite="mid:511C91DF.20106@oracle.com" type="cite">
<div class="moz-cite-prefix"> <br>
A couple of minor comments:<br>
<br>
Since ProcessBuilder.command() takes variable number of String
arguments, you don't have to create a String[] yourself. You can
let the JDK do that for you. So, this line:<br>
<br>
pb.command(new String[] { JDKToolFinder.getJDKTool("jcmd"),
pid, "Thread.print"}); <br>
<br>
Could be simplified to:<br>
<br>
pb.command(JDKToolFinder.getJDKTool("jcmd"), pid,
"Thread.print"); <br>
</div>
</blockquote>
<br>
OK. I followed Christian Tornqvist's guidelines and the code was
checked against the AllocTypeTest.java regression test in the NMT
tests. I thought it was a convention.<br>
<br>
<blockquote cite="mid:511C91DF.20106@oracle.com" type="cite">
<div class="moz-cite-prefix"> Also, you call the test Test8005875.
I think this is what we used to do. But I have been told that it
is better to use the @bug tag to indicate the bug number and
call the test something meaningful. I like this much better
since if the test fails you can actually get a clue of what is
going wrong.<br>
<br>
And I think you should give a name to the @name tag<br>
<br>
So I would prefer something like:<br>
<br>
/* @test TestG1JcmdThreadPrint<br>
* @bug 8005875<br>
* @summary Use jcmd to generate a thread dump of a Java program
being run with G1 and PGCT=0 to verify 8005875<br>
* @library /testlibrary<br>
* @run main/othervm -XX:+UseG1GC -XX:ParallelGCThreads=0
-XX:+IgnoreUnrecognizedVMOptions TestG1JcmdThreadPrint<br>
*/<br>
<br>
import com.oracle.java.testlibrary.*;<br>
<br>
<meta http-equiv="content-type" content="text/html;
charset=UTF-8">
public class TestG1JcmdThreadPrint {<br>
</div>
</blockquote>
<br>
Sure, no problem.<br>
</body>
</html>