<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">Looks good.<br>
<br>
You should probably remove the atomic.hpp include.<br>
<br>
StefanK<br>
<br>
On 02/18/2013 02:21 PM, Bengt Rutisson wrote:<br>
</div>
<blockquote cite="mid:51222ACE.1000402@oracle.com" type="cite">
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
<br>
Hi all,<br>
<br>
Could I have a couple of reviews for this change?<br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Ebrutisso/8008382/webrev.00/">http://cr.openjdk.java.net/~brutisso/8008382/webrev.00/</a><br>
<br>
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
There is no need to use atomics in create_new_gc_id() since it is
not called by multiple threads in parallel. Also,
Atomic::add(jlong, jlong *) is broken for ARM. <br>
<br>
We should remove the use of Atomic::add in create_new_gc_id() for
now. If we need this to be called by multiple threads in the
future we have to reconsider how this should be done. Either
adding a lock or doing some kind of 32 bit atomic work.<br>
<br>
Thanks,<br>
Bengt<br>
</blockquote>
<br>
</body>
</html>