<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Tao,<br>
<br>
Why this change from resize_old_gen() to<br>
resize_tenured_gen()? There are many<br>
variable names and comments referring to<br>
"old gen" still in ParallelScavengeHeap.<br>
<br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~tamao/8007762/webrev.00/src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.cpp.udiff.html">http://cr.openjdk.java.net/~tamao/8007762/webrev.00/src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.cpp.udiff.html</a><br>
<br>
Jon<br>
<br>
On 02/14/13 11:18, Tao Mao wrote:
<blockquote cite="mid:511D388A.4010700@oracle.com" type="cite">
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
8007762: Rename a bunch of methods in size policy across
collectors<br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="https://jbs.oracle.com/bugs/browse/JDK-8007762">https://jbs.oracle.com/bugs/browse/JDK-8007762</a><br>
<br>
webrev: <br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Etamao/8007762/webrev.00/">http://cr.openjdk.java.net/~tamao/8007762/webrev.00/</a><br>
<br>
changeset:<br>
The motivation of this change is associated with CR 7098155 (<a
moz-do-not-send="true" class="moz-txt-link-freetext"
href="https://jbs.oracle.com/bugs/browse/JDK-7098155">https://jbs.oracle.com/bugs/browse/JDK-7098155</a>).
For this, we need to split compute_generations_free_space into two
routine (one for compute_eden_space_size and the other for
compute_tenured_generation_free_space) in order to save some
overhead when we want to compute only one of the two. The next
step is to split
PSAdaptiveSizePolicy::compute_generations_free_space(), which will
be resolved in CR 8007763.<br>
<br>
To unify the naming, a bunch of routines are renamed here.<br>
(1) compute_*: <br>
compute_survivor_space_size_and_threshold() <br>
compute_generations_free_space() = compute_eden_space_size()
+ compute_tenured_generation_free_space()<br>
(2) resize_*_gen: <br>
resize_young_gen() <br>
resize_tenured_gen() <br>
(3) rename judging routine resize_geneneration() to need_resize()
to avoid ambiguity<span style="color: rgb(0, 0, 0); font-family:
Arial, FreeSans, Helvetica, sans-serif; font-size: 13px;
font-style: normal; font-variant: normal; font-weight: normal;
letter-spacing: normal; line-height: 17px; orphans: 2;
text-align: start; text-indent: 0px; text-transform: none;
white-space: normal; widows: 2; word-spacing: 0px;
-webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;
background-color: rgb(255, 255, 255); display: inline
!important; float: none;"></span><br>
<br>
testing:<br>
purely renaming; passed JPRT<br>
<br>
</blockquote>
</body>
</html>