<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix"><br>
Hi Vladimir,<br>
<br>
Looks good!<br>
<br>
(Adding back the hotspot-gc-dev mailing list.)<br>
<br>
Thanks,<br>
Bengt<br>
<br>
On 2/20/13 4:16 PM, vladimir kempik wrote:<br>
</div>
<blockquote cite="mid:5124E8D3.7030800@oracle.com" type="cite">
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
<pre style="white-space: pre-wrap">Hi Bengt,
Thanks for looking at this!
Here is an updated webrev based on your feedback:
<a moz-do-not-send="true" href="http://cr.openjdk.java.net/%7Ebrutisso/8002144/webrev.01/">http://cr.openjdk.java.net/~mcherkas/vladimir/8008546/webrev.01/
</a>
I applied what you suggested.
Thanks,
Vladimir.
</pre>
<div class="moz-cite-prefix">On 20.02.2013 17:54, Bengt Rutisson
wrote:<br>
</div>
<blockquote cite="mid:5124D578.2030405@oracle.com" type="cite"> <br>
Hi Vladimir, <br>
<br>
This looks very similar to how we treat G1ReservePercent, so I
think it looks good. An alternative would have been to check
this earlier in the initialization phase and update the flag
G1ConfidencePercent so that PrintFlagsFinal would have printed
the actual value. But for consistency I think it looks good this
way. <br>
<br>
I think you can change G1ConfidencePercent to be an uintx
instead of intx (in g1_globals.hpp). In that case you don't need
the second if statment since it can't be less than 0. It is also
more consistent with G1ReservePercent which is an uintx. <br>
<br>
Thanks, <br>
Bengt <br>
<br>
On 2/20/13 2:31 PM, vladimir kempik wrote: <br>
<blockquote type="cite">Hi all, <br>
<br>
Could I have a couple of reviews for this change? <br>
<br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Emcherkas/vladimir/8008546/webrev.00/">http://cr.openjdk.java.net/~mcherkas/vladimir/8008546/webrev.00/</a>
<br>
<br>
Input value for G1CONFIDENCEPERCENT wasn't checked before
using. This results in crash sometimes if -XX:+UseG1GC
-XX:G1ConfidencePercent=200 flags are used. Now checking the
value same way as it was done for G1ReservePercent. Increase
to 0 if negative, decrease to 100 if more than 100. <br>
<br>
Thanks, <br>
Vladimir <br>
<br>
</blockquote>
<br>
</blockquote>
<br>
</blockquote>
<br>
</body>
</html>