<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
Hello John.<br>
<br>
A customer was running an own <span id="mainframespan"><font
color="RED"><font color="#000000">java program which keeps
allocating memory. <br>
<br>
Thanks,<br>
Vladimir<br>
</font></font><tt><font color="RED"></font></tt></span>
<div class="moz-cite-prefix">On 21.02.2013 0:13, John Cuthbertson
wrote:<br>
</div>
<blockquote cite="mid:51252E70.3070300@oracle.com" type="cite">Hi
Vladimir,
<br>
<br>
The change looks good to me. But I have a question: which counter
was tripping the guarantee? I just ran jvm98 with a confidence
percent value of 200 and 300 and the guarantee didn't fire for me.
<br>
<br>
I kind of agree with Bengt that moving this kind of error checking
earlier would be better. But that can be done as a separate CR.
<br>
<br>
Thanks,
<br>
<br>
JohnC
<br>
<br>
On 2/20/2013 7:27 AM, vladimir kempik wrote:
<br>
<blockquote type="cite">Hi Bengt,
<br>
<br>
Thanks for looking at this!
<br>
<br>
Here is an updated webrev based on your feedback:
<br>
<br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~mcherkas/vladimir/8008546/webrev.01/">http://cr.openjdk.java.net/~mcherkas/vladimir/8008546/webrev.01/</a>
<br>
<br>
I applied what you suggested.
<br>
<br>
Thanks,
<br>
Vladimir.
<br>
<br>
On 20.02.2013 17:54, Bengt Rutisson wrote:
<br>
<blockquote type="cite">
<br>
Hi Vladimir,
<br>
<br>
This looks very similar to how we treat G1ReservePercent, so I
think it looks good. An alternative would have been to check
this earlier in the initialization phase and update the flag
G1ConfidencePercent so that PrintFlagsFinal would have printed
the actual value. But for consistency I think it looks good
this way.
<br>
<br>
I think you can change G1ConfidencePercent to be an uintx
instead of intx (in g1_globals.hpp). In that case you don't
need the second if statment since it can't be less than 0. It
is also more consistent with G1ReservePercent which is an
uintx.
<br>
<br>
Thanks,
<br>
Bengt
<br>
<br>
On 2/20/13 2:31 PM, vladimir kempik wrote:
<br>
<blockquote type="cite">Hi all,
<br>
<br>
Could I have a couple of reviews for this change?
<br>
<br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~mcherkas/vladimir/8008546/webrev.00/">http://cr.openjdk.java.net/~mcherkas/vladimir/8008546/webrev.00/</a>
<br>
<br>
Input value for G1CONFIDENCEPERCENT wasn't checked before
using. This results in crash sometimes if -XX:+UseG1GC
-XX:G1ConfidencePercent=200 flags are used. Now checking the
value same way as it was done for G1ReservePercent. Increase
to 0 if negative, decrease to 100 if more than 100.
<br>
<br>
Thanks,
<br>
Vladimir
<br>
<br>
</blockquote>
<br>
</blockquote>
<br>
</blockquote>
<br>
</blockquote>
<br>
</body>
</html>