<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix"><br>
Hi Erik,<br>
<br>
I think this looks good.<br>
<br>
One question: <br>
<br>
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
CMSCollector::register_gc_start() is currently called like this:<br>
<br>
register_gc_start(GenCollectedHeap::heap()->gc_cause());<br>
<br>
With your patch you look up the heap inside
CMSCollector::register_gc_start() to call
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
trace_heap_before_gc() on it. What do you think about passing the
heap to CMSCollector::register_gc_start() instead of passing the
cause?<br>
<br>
Thanks,<br>
Bengt<br>
<br>
<br>
<br>
On 2/24/13 10:40 AM, Erik Helin wrote:<br>
</div>
<blockquote cite="mid:5129E024.2040900@oracle.com" type="cite">Hi
all,
<br>
<br>
this change adds the trace event vm/gc/heap/summary to the CMS
collector.
<br>
<br>
Webrev:
<br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~ehelin/8008737/webrev.00/">http://cr.openjdk.java.net/~ehelin/8008737/webrev.00/</a>
<br>
<br>
Bug:
<br>
<a class="moz-txt-link-freetext" href="http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8008737">http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8008737</a>
<br>
<br>
Testing:
<br>
JPRT
<br>
<br>
Thanks,
<br>
Erik
<br>
</blockquote>
<br>
</body>
</html>