<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto"><div style="-webkit-text-size-adjust: auto; "><br></div><div style="-webkit-text-size-adjust: auto; ">Hi Jesper,</div><div style="-webkit-text-size-adjust: auto; "><br></div><div style="-webkit-text-size-adjust: auto; ">Looks good.</div><div style="-webkit-text-size-adjust: auto; "><br></div><div style="-webkit-text-size-adjust: auto; ">I think you can move this line down to after the early exit too:</div><div><pre><font face="Helvetica"><span style="white-space: normal; -webkit-text-size-adjust: auto; background-color: rgba(255, 255, 255, 0);">
894 ParNewTracer gc_tracer;</span></font></pre></div><div style="-webkit-text-size-adjust: auto; ">Bengt</div><div style="-webkit-text-size-adjust: auto; "><br>11 mar 2013 kl. 18:59 skrev Jesper Wilhelmsson <<a href="mailto:jesper.wilhelmsson@oracle.com">jesper.wilhelmsson@oracle.com</a>>:<br><br></div><blockquote type="cite" style="-webkit-text-size-adjust: auto; "><div><span>Hi,</span><br><span></span><br><span>Looking for a couple of reviews for this small fix.</span><br><span></span><br><span>If there is a risk for promotion failure then ParNew can decide to do an early exit. In ParNew::collect, the heap summary event is sent before this check, which means that there might be a heap summary without a corresponding garbage collection event.</span><br><span></span><br><span>The fix is to send the event after the early exit.</span><br><span></span><br><span>Bug: <a href="http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8007003">http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8007003</a></span><br><span></span><br><span>Webrev: <a href="http://cr.openjdk.java.net/~jwilhelm/8007003/webrev/">http://cr.openjdk.java.net/~jwilhelm/8007003/webrev/</a></span><br><span></span><br><span>Thanks,</span><br><span>/Jesper</span><br></div></blockquote></body></html>