<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
The comment <br>
<br>
"
<meta charset="utf-8">
1172 // MaxHeapSize is aligned down in collectorPolicy"<br>
<br>
mislead here so I deleted it (because: in fact, in
collectorPolicy.cpp, MaxHeapSize is aligned up). But the assertions
still have some value.<br>
<br>
Please review the new webrev.<br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~tamao/7196080/webrev.01/">http://cr.openjdk.java.net/~tamao/7196080/webrev.01/</a><br>
<br>
Thanks.<br>
Tao<br>
<br>
On 3/7/13 1:10 PM, Jon Masamitsu wrote:
<blockquote cite="mid:5139022B.4070209@oracle.com" type="cite">Tao,
<br>
<br>
As per our discussion feel free to delete both
<br>
assertions.
<br>
<br>
Jon
<br>
<br>
On 03/07/13 08:13, Jon Masamitsu wrote:
<br>
<blockquote type="cite">Tao,
<br>
<br>
The original assertion seems a worthwhile one
<br>
(i.e., the maximum heap size is >= to the
<br>
initial heap size) to enforce. The CR says the problem
<br>
that not everything has been page aligned. Is
<br>
the latter not true?
<br>
<br>
Jon
<br>
<br>
On 03/06/13 14:33, Tao Mao wrote:
<br>
<blockquote type="cite">7196080: assert(max_heap >=
InitialHeapSize) in arguments.cpp
<br>
<a class="moz-txt-link-freetext" href="https://jbs.oracle.com/bugs/browse/JDK-7196080">https://jbs.oracle.com/bugs/browse/JDK-7196080</a>
<br>
<br>
webrev:
<br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~tamao/7196080/webrev.00/">http://cr.openjdk.java.net/~tamao/7196080/webrev.00/</a>
<br>
<br>
changeset:
<br>
1. inequality doesn't transfer here.
<br>
X >= align_down(X)
<br>
X >= I
<br>
altogether, cannot infer that align_down(X) >= I. Simple
math!
<br>
So, I have removed the original assertion "max_heap >=
InitialHeapSize".
<br>
2. It's reasonable to check an extra assertion "max_heap >
= OldSize", following the comment above the assertions.
<br>
</blockquote>
</blockquote>
</blockquote>
</body>
</html>