<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix"><br>
Hi Tao,<br>
<br>
The change looks good.<br>
<br>
The bug report is a little sparse on information - it basically
just contains the title. I think it could be worth adding a line
about why we want to do this and maybe also comment on why you
update the message for
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
MaxGCMinorPauseMillis.<br>
<br>
Something like:<br>
<br>
"When Arguments::check_deprecated_gcs() was added the check for
the use of the deprecated flag CMSIncrementalMode was included
there. Later the
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
Arguments::check_deprecated_gc_flags() method was added. Since the
CMSIncrementalMode is just a flag it seems more logical to check
it in Arguments::check_deprecated_gc_flags() than in
Arguments::check_deprecated_gcs()."<br>
<br>
You can probably come up with a short comment on the
MaxGCMinorPauseMillis message update. This was not suggested by
me, so I'll let you figure something out ;)<br>
<br>
Bengt<br>
<br>
On 3/22/13 12:23 AM, Tao Mao wrote:<br>
</div>
<blockquote cite="mid:514B966E.4060706@oracle.com" type="cite">A
simple changeset. Need a reviewer!
<br>
<br>
8010518 Move deprecating CMSIncrementalMode from
Arguments::check_deprecated_gcs() to
Arguments::check_deprecated_gc_flags()
<br>
<a class="moz-txt-link-freetext" href="https://jbs.oracle.com/bugs/browse/JDK-8010518">https://jbs.oracle.com/bugs/browse/JDK-8010518</a>
<br>
<br>
webrev:
<br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~tamao/8010518/webrev.00/">http://cr.openjdk.java.net/~tamao/8010518/webrev.00/</a>
<br>
<br>
changeset:
<br>
Cleanup suggested by Bengt.
<br>
</blockquote>
<br>
</body>
</html>