<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix"><br>
Hi Tao,<br>
<br>
On 3/23/13 4:51 AM, Tao Mao wrote:<br>
</div>
<blockquote cite="mid:514D26D2.1030705@oracle.com" type="cite">Thank
you for review and suggestion. A new webrev is updated.
<br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~tamao/8010518/webrev.01/">http://cr.openjdk.java.net/~tamao/8010518/webrev.01/</a>
<br>
</blockquote>
<br>
I like Jon's suggestion about removing the word "likely" but that
means that you need to update these tests:<br>
<br>
test/gc/startup_warnings/TestCMSIncrementalMode.java<br>
test/gc/startup_warnings/TestIncGC.java<br>
<br>
Also, would it make sense to remove the word "likely" from the
warning messages in
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
Arguments::check_deprecated_gcs() too? In that case you need to
update these tests as well:<br>
<br>
test/gc/startup_warnings/TestDefNewCMS.java<br>
test/gc/startup_warnings/TestParNewSerialOld.java<br>
<br>
Bengt<br>
<br>
<blockquote cite="mid:514D26D2.1030705@oracle.com" type="cite">
<br>
Tao
<br>
<br>
On 3/22/13 1:56 PM, Jon Masamitsu wrote:
<br>
<blockquote type="cite">Tao,
<br>
<br>
Changes look fine. I would remove the "likely" so that messages
read like
<br>
<br>
"and will be removed in a future release"
<br>
<br>
Fewer words are better and the intent is still clear.
<br>
<br>
Jon
<br>
<br>
<br>
On 3/21/2013 4:23 PM, Tao Mao wrote:
<br>
<blockquote type="cite">A simple changeset. Need a reviewer!
<br>
<br>
8010518 Move deprecating CMSIncrementalMode from
Arguments::check_deprecated_gcs() to
Arguments::check_deprecated_gc_flags()
<br>
<a class="moz-txt-link-freetext" href="https://jbs.oracle.com/bugs/browse/JDK-8010518">https://jbs.oracle.com/bugs/browse/JDK-8010518</a>
<br>
<br>
webrev:
<br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~tamao/8010518/webrev.00/">http://cr.openjdk.java.net/~tamao/8010518/webrev.00/</a>
<br>
<br>
changeset:
<br>
Cleanup suggested by Bengt.
<br>
</blockquote>
<br>
</blockquote>
</blockquote>
<br>
</body>
</html>