<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix"><br>
Hi Erik,<br>
<br>
Changes look good!<br>
<br>
One minor nit. I think the test contains the wrong bug number:<br>
<br>
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
* @bug 8004924<br>
<br>
Bengt<br>
<br>
On 3/25/13 9:32 AM, Erik Helin wrote:<br>
</div>
<blockquote cite="mid:51500BBB.8070702@oracle.com" type="cite">All,
<br>
<br>
I have updated the change based on internal feedback.
<br>
<br>
The changes between webrev.00 and webrev.01 are mostly in the test
code:
<br>
- The test uses correct @summary description
<br>
- The test now uses the correct command line flags
<br>
- The test is more documented to describe how the test code is run
<br>
<br>
There is also a very minor change in the hotspot code. I am now
using the operator != instead of operator > when comparing the
missed count. This was done just to make the diff one line smaller
:)
<br>
<br>
Please see new webrev at:
<br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~ehelin/8010294/webrev.01/">http://cr.openjdk.java.net/~ehelin/8010294/webrev.01/</a>
<br>
<br>
Thanks,
<br>
Erik
<br>
<br>
On 03/22/2013 10:06 AM, Erik Helin wrote:
<br>
<blockquote type="cite">Hi all,
<br>
<br>
I have refactored the HeapInspection class to prepare for the
<br>
vm/gc/detailed/object_count_after_gc event.
<br>
<br>
The refactoring mainly consists of breaking up the rather long
<br>
heap_inspect function to multiple small functions that can be
reused.
<br>
<br>
I also moved the public enums used to initialize KlassInfoTable
and
<br>
KlassInfoHisto to private constants. Now they no longer have to
be
<br>
passed as an argument to the constructor.
<br>
<br>
I also added a test to ensure that my refactoring did not break
anything
<br>
(the test is not that extensive but at least it ensures that the
basic
<br>
stuff is working).
<br>
<br>
Webrev:
<br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~ehelin/8010294/webrev.00/">http://cr.openjdk.java.net/~ehelin/8010294/webrev.00/</a>
<br>
<br>
Bug:
<br>
<a class="moz-txt-link-freetext" href="http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8010294">http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8010294</a>
<br>
<br>
Testing:
<br>
- JPRT
<br>
- A new jtreg test (see webrev)
<br>
<br>
Thanks,
<br>
Erik
<br>
</blockquote>
<br>
</blockquote>
<br>
</body>
</html>