<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix"><br>
Hi Tao,<br>
<br>
On 3/27/13 11:45 PM, Tao Mao wrote:<br>
</div>
<blockquote cite="mid:51537686.1030601@oracle.com" type="cite">
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
Please see inline.<br>
Tao<br>
<br>
On 3/25/13 9:56 PM, Bengt Rutisson wrote:
<blockquote cite="mid:51512A97.2030600@oracle.com" type="cite">
<meta content="text/html; charset=UTF-8"
http-equiv="Content-Type">
<div class="moz-cite-prefix"><br>
Hi Tao,<br>
<br>
Thanks for updating the tests. Looks good to me.<br>
<br>
Have you tried running the tests? It is a very small change so
it should be ok. But our testing process is very strange and
it may be that these tests are not run until PIT testing, so
running them once before pushing is a good idea to avoid
unnecessary issues later on.<br>
</div>
</blockquote>
They have passed the jtreg tests. I'm going to push it.<br>
<br>
script:<br>
jtreg -jdk:/Users/tamao/home/jdk1.8.0_b74_macosx/ \<br>
-vmoption:-tamao \<br>
./src/8010518MoveDeprecatingCMSIncrementalMode/test/gc/startup_warnings/TestCMSIncrementalMode.java
\<br>
./src/8010518MoveDeprecatingCMSIncrementalMode/test/gc/startup_warnings/TestIncGC.java<br>
<br>
results:<br>
Test results: passed: 2<br>
Report written to
/Users/tamao/Dropbox/Oracle/JTreport/html/report.html<br>
Results written to /Users/tamao/Dropbox/Oracle/JTwork<br>
</blockquote>
<br>
Great! Thanks!<br>
<br>
<blockquote cite="mid:51537686.1030601@oracle.com" type="cite">
<blockquote cite="mid:51512A97.2030600@oracle.com" type="cite">
<div class="moz-cite-prefix"> <br>
Also, I see that you decided not to remove "likely" from the
other messages in Arguments::check_deprecated_gcs(). Would you
like to do that as a separate change or do you think we should
leave those messages unchanged?<br>
</div>
</blockquote>
So what was the decision for deprecating these gc's? To me, there
hasn't seemed to be any definitive decision, yet.<br>
</blockquote>
<br>
It is the same decision as for CMSIncrementalMode, where you removed
the "likely".<br>
<br>
Bengt<br>
<br>
<blockquote cite="mid:51537686.1030601@oracle.com" type="cite">
<blockquote cite="mid:51512A97.2030600@oracle.com" type="cite">
<div class="moz-cite-prefix"> <br>
Thanks,<br>
Bengt<br>
<br>
On 3/25/13 7:48 PM, Tao Mao wrote:<br>
</div>
<blockquote cite="mid:51509C17.6080808@oracle.com" type="cite">
<meta content="text/html; charset=UTF-8"
http-equiv="Content-Type">
Thank you for pointing it out, Bengt. A new webrev is updated.<br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Etamao/8010518/webrev.02/">http://cr.openjdk.java.net/~tamao/8010518/webrev.02/</a><br>
<br>
Please see inline.<br>
Tao<br>
<br>
On 3/24/13 1:16 PM, Bengt Rutisson wrote:
<blockquote cite="mid:514F5F16.9080909@oracle.com" type="cite">
<meta content="text/html; charset=UTF-8"
http-equiv="Content-Type">
<div class="moz-cite-prefix"><br>
Hi Tao,<br>
<br>
On 3/23/13 4:51 AM, Tao Mao wrote:<br>
</div>
<blockquote cite="mid:514D26D2.1030705@oracle.com"
type="cite">Thank you for review and suggestion. A new
webrev is updated. <br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Etamao/8010518/webrev.01/">http://cr.openjdk.java.net/~tamao/8010518/webrev.01/</a>
<br>
</blockquote>
<br>
I like Jon's suggestion about removing the word "likely" but
that means that you need to update these tests:<br>
<br>
test/gc/startup_warnings/TestCMSIncrementalMode.java<br>
test/gc/startup_warnings/TestIncGC.java<br>
</blockquote>
Test files modified.<br>
<blockquote cite="mid:514F5F16.9080909@oracle.com" type="cite">
<br>
Also, would it make sense to remove the word "likely" from
the warning messages in
<meta http-equiv="content-type" content="text/html;
charset=UTF-8">
Arguments::check_deprecated_gcs() too? In that case you need
to update these tests as well:<br>
<br>
test/gc/startup_warnings/TestDefNewCMS.java<br>
test/gc/startup_warnings/TestParNewSerialOld.java<br>
</blockquote>
Have we made a decision to certainly remove these gc comb's in
future? If so, it's OK to state so. Anyway, it would be better
to resolve it with a separate CR. <br>
<blockquote cite="mid:514F5F16.9080909@oracle.com" type="cite">
<br>
Bengt<br>
<br>
<blockquote cite="mid:514D26D2.1030705@oracle.com"
type="cite"> <br>
Tao <br>
<br>
On 3/22/13 1:56 PM, Jon Masamitsu wrote: <br>
<blockquote type="cite">Tao, <br>
<br>
Changes look fine. I would remove the "likely" so that
messages read like <br>
<br>
"and will be removed in a future release" <br>
<br>
Fewer words are better and the intent is still clear. <br>
<br>
Jon <br>
<br>
<br>
On 3/21/2013 4:23 PM, Tao Mao wrote: <br>
<blockquote type="cite">A simple changeset. Need a
reviewer! <br>
<br>
8010518 Move deprecating CMSIncrementalMode from
Arguments::check_deprecated_gcs() to
Arguments::check_deprecated_gc_flags() <br>
<a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="https://jbs.oracle.com/bugs/browse/JDK-8010518">https://jbs.oracle.com/bugs/browse/JDK-8010518</a>
<br>
<br>
webrev: <br>
<a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Etamao/8010518/webrev.00/">http://cr.openjdk.java.net/~tamao/8010518/webrev.00/</a>
<br>
<br>
changeset: <br>
Cleanup suggested by Bengt. <br>
</blockquote>
<br>
</blockquote>
</blockquote>
<br>
</blockquote>
</blockquote>
<br>
</blockquote>
</blockquote>
<br>
</body>
</html>