<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
Hi Martin,<br>
<br>
This looks good to me. Coleen has also reviewed the change and given
it the thumbs up. I'll let you get back to me regarding a test case
before pushing the changes.<br>
<br>
JohnC<br>
<br>
<div class="moz-cite-prefix">On 4/16/2013 1:38 AM, Doerr, Martin
wrote:<br>
</div>
<blockquote
cite="mid:7C9B87B351A4BA4AA9EC95BB4181165668F42BED@DEWDFEMB13A.global.corp.sap"
type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=ISO-8859-1">
<meta name="Generator" content="Microsoft Word 14 (filtered
medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";
mso-fareast-language:EN-US;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
pre
{mso-style-priority:99;
mso-style-link:"HTML Preformatted Char";
margin:0cm;
margin-bottom:.0001pt;
font-size:10.0pt;
font-family:"Courier New";}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri","sans-serif";
color:windowtext;}
span.HTMLPreformattedChar
{mso-style-name:"HTML Preformatted Char";
mso-style-priority:99;
mso-style-link:"HTML Preformatted";
font-family:"Courier New";
mso-fareast-language:DE;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri","sans-serif";
mso-fareast-language:EN-US;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:70.85pt 70.85pt 2.0cm 70.85pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<div class="WordSection1">
<p class="MsoNormal">Hi all,<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span lang="EN-US">we found a G1 bug i</span><span
style="mso-fareast-language:DE" lang="EN-US">n the template
interpreter on x86_64 and sparc with compressed Oops.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:DE"
lang="EN-US">“do_oop_store” performs a “</span><span
style="color:black;background:silver;mso-highlight:silver"
lang="EN-US">store_heap_oop</span><span style="color:black"
lang="EN-US">” which compresses the input register.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:black" lang="EN-US">This
compressed Oop is passed to the succeeding
</span><span style="mso-fareast-language:DE" lang="EN-US">g1_write_barrier_post,
which is wrong.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:DE"
lang="EN-US">Correctly, g1_write_barrier_post needs the
uncompressed Oop for the heap region crossing check.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:DE"
lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:DE"
lang="EN-US">This fix preserves the uncompressed Oop in a
register which gets passed to the g1_write_barrier_post:<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:DE"
lang="EN-US"><a moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Egoetz/webrevs/g1-cOops_bug/">http://cr.openjdk.java.net/~goetz/webrevs/g1-cOops_bug/</a><o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:DE"
lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:DE"
lang="EN-US">Please supply a bug id and review this change.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:DE"
lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:DE"
lang="EN-US">Kind regards,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:DE"
lang="EN-US">Martin<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:DE"
lang="EN-US"><o:p> </o:p></span></p>
</div>
</blockquote>
<br>
</body>
</html>