<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix"><br>
Leonid,<br>
<br>
Thanks for looking at this.<br>
<br>
On 4/17/13 12:16 PM, Leonid Mesnik wrote:<br>
</div>
<blockquote cite="mid:516E7686.7040008@oracle.com" type="cite">Bengt
<br>
<br>
Could you please add a unit test for this fix.
<br>
</blockquote>
<br>
I am not too keen on writing a test for this. I see your point, but
the fix is very small and we already have lots of code that does the
same thing without any tests. If we should add a test I think it
should be for
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
PrintGCTimeStamps and PrintGCDateStamps in general. However, I don't
think our logging is parsable enough to make such a test stable.
Timestamps can get mixed in in the middle of lines and unexpected
messages can be logged at almost any point in time.<br>
<br>
Thanks,<br>
Bengt<br>
<br>
<br>
<br>
<blockquote cite="mid:516E7686.7040008@oracle.com" type="cite">
<br>
Leonid
<br>
On 04/17/2013 12:47 PM, Bengt Rutisson wrote:
<br>
<blockquote type="cite">
<br>
Hi all,
<br>
<br>
Can I have a couple of reviews for this very small change?
<br>
<br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~brutisso/8012455/webrev.00/">http://cr.openjdk.java.net/~brutisso/8012455/webrev.00/</a>
<br>
<br>
Background
<br>
<br>
A customer commented that it is hard to coordinate the
information from PrintGCApplicationConcurrentTime and
PrintGCApplicationStoppedTime with the information from PrintGC
and PrintGCDetails in stable way since the former flags don't
include timestamps.
<br>
<br>
This patch adds time and date stamps to the output from
PrintGCApplicationConcurrentTime and
PrintGCApplicationStoppedTime.
<br>
<br>
Thanks,
<br>
Bengt
<br>
</blockquote>
<br>
<br>
</blockquote>
<br>
</body>
</html>