<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">Bengt <br>
<br>
Thank you for tagging issue. <br>
I think noreg-sqe is not correct. The fix is not really covered by
existing tests. <br>
However noreg-hard could be used here. (Hard to develop stable
test) <br>
<br>
Leonid<br>
<br>
On 04/17/2013 05:10 PM, Bengt Rutisson wrote:<br>
</div>
<blockquote cite="mid:516E9F2B.4050801@oracle.com" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
<div class="moz-cite-prefix"><br>
On 4/17/13 2:31 PM, Coleen Phillimore wrote:<br>
</div>
<blockquote cite="mid:516E9629.3020508@oracle.com" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
<div class="moz-cite-prefix"><br>
I think this is noreg-sqe ? Do you have a pointer to this
document?<br>
<pre>Here is the pointer to the description for labels for regression or no
regression tests on fixed bugs:
<a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://openjdk.java.net/guide/changePlanning.html#bug">http://openjdk.java.net/guide/changePlanning.html#bug</a>
See Step #6</pre>
</div>
</blockquote>
<br>
Thanks, Coleen!<br>
<br>
I tagged the bug with noreg-sqe and added a comment.<br>
<br>
Bengt<br>
<br>
<blockquote cite="mid:516E9629.3020508@oracle.com" type="cite">
<div class="moz-cite-prefix"> <br>
Coleen<br>
<br>
On 4/17/2013 7:01 AM, Bengt Rutisson wrote:<br>
</div>
<blockquote cite="mid:516E8115.9030500@oracle.com" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
<div class="moz-cite-prefix"><br>
Leonid,<br>
<br>
Thanks for looking at this.<br>
<br>
On 4/17/13 12:16 PM, Leonid Mesnik wrote:<br>
</div>
<blockquote cite="mid:516E7686.7040008@oracle.com" type="cite">Bengt
<br>
<br>
Could you please add a unit test for this fix. <br>
</blockquote>
<br>
I am not too keen on writing a test for this. I see your
point, but the fix is very small and we already have lots of
code that does the same thing without any tests. If we should
add a test I think it should be for
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
PrintGCTimeStamps and PrintGCDateStamps in general. However, I
don't think our logging is parsable enough to make such a test
stable. Timestamps can get mixed in in the middle of lines and
unexpected messages can be logged at almost any point in time.<br>
<br>
Thanks,<br>
Bengt<br>
<br>
<br>
<br>
<blockquote cite="mid:516E7686.7040008@oracle.com" type="cite">
<br>
Leonid <br>
On 04/17/2013 12:47 PM, Bengt Rutisson wrote: <br>
<blockquote type="cite"> <br>
Hi all, <br>
<br>
Can I have a couple of reviews for this very small change?
<br>
<br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Ebrutisso/8012455/webrev.00/">http://cr.openjdk.java.net/~brutisso/8012455/webrev.00/</a>
<br>
<br>
Background <br>
<br>
A customer commented that it is hard to coordinate the
information from PrintGCApplicationConcurrentTime and
PrintGCApplicationStoppedTime with the information from
PrintGC and PrintGCDetails in stable way since the former
flags don't include timestamps. <br>
<br>
This patch adds time and date stamps to the output from
PrintGCApplicationConcurrentTime and
PrintGCApplicationStoppedTime. <br>
<br>
Thanks, <br>
Bengt <br>
</blockquote>
<br>
<br>
</blockquote>
<br>
</blockquote>
<br>
</blockquote>
<br>
</blockquote>
<br>
<br>
<pre class="moz-signature" cols="72">--
Leonid Mesnik
JVM SQE</pre>
</body>
</html>