<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix"><br>
Hi Jon,<br>
<br>
Looks good!<br>
<br>
A few minor nits in the JTreg test:<br>
<br>
- I think the "@test" line should have the test name in it. So,
"@test
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
GuardShrinkWarning".<br>
<br>
- I don't think you need the "Go" parameter on line 45.<br>
<br>
- Why do you need the loop in SystemGCCaller to do 50 System.gc()
calls? I think the warning is printed for every GC, so one
System.gc() call should be enough, right?<br>
<br>
- Do you need the "garbage" that you create in SystemGCCaller? I
also think you can drop the System.println(".") call. <br>
<br>
Thanks,<br>
Bengt<br>
<br>
<br>
On 4/19/13 8:41 PM, Jon Masamitsu wrote:<br>
</div>
<blockquote cite="mid:51718FCC.9070207@oracle.com" type="cite">8012111:
Remove warning about CMS generation shrinking.
<br>
<br>
The warning message
<br>
<br>
"Java HotSpot(TM) Server VM warning: Shrinking of CMS not yet
implemented"
<br>
<br>
should not generally be emitted. Guard it with PrintGCDetails and
Verbose.
<br>
<br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~jmasa/8012111/webrev.00/">http://cr.openjdk.java.net/~jmasa/8012111/webrev.00/</a>
<br>
</blockquote>
<br>
</body>
</html>