<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix"><br>
Hi John,<br>
<br>
This looks good.<br>
<br>
A couple of questions:<br>
<br>
The test is pretty verbose. Do you really want to keep all the
System.out.print-ing?<br>
<br>
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
51 System.out.print("Testing:\n" +
JDKToolFinder.getJDKTool("java"));<br>
52 for (int i = 0; i < vmOpts.size(); i += 1) {<br>
53 System.out.print(" " + vmOpts.get(i));<br>
54 }<br>
55 System.out.println();<br>
<br>
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
61 System.out.println("Output:\n" + output.getOutput());<br>
<br>
If you remove the printing at line 51 I guess you can also remove
the import of JDKToolsFinder.<br>
<br>
Thanks,<br>
Bengt<br>
<br>
<br>
On 4/24/13 2:15 AM, John Cuthbertson wrote:<br>
</div>
<blockquote cite="mid:5177243D.9030006@oracle.com" type="cite">Hi
Everyone,
<br>
<br>
Can I have a couple of volunteers review these changes to the
regression test I added for 8010463 and changed for 8011343? The
webrev can found at:
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~johnc/8011898/webrev.0/">http://cr.openjdk.java.net/~johnc/8011898/webrev.0/</a>
<br>
<br>
Summary:
<br>
The call to System.getProperty("test.vm.opts") will return null if
no additional vm or java options are passed into jtreg. Hence the
first entry in the String array, that is passed to
createJavaProcessBuilder(), is null. When the null is converted to
options, the first option will be the empty string which the java
launcher interprets as the name of the main class.
<br>
<br>
Many thanks to Bengt for his diagnosis.
<br>
<br>
Notes:
<br>
<br>
In this test I'm using the same mechanism as in Tao's test for
6761744. His is much nicer than what I came up with. Many tanks to
Tao.
<br>
<br>
The test now reads the test.java.opts instead of test.vm.opts
after feedback from SQE.
<br>
<br>
Also I added a couple of prints to test to make it easier to see
what the command line of the child java process actually is and
it's resulting output. In the .jtr file you see something like:
<br>
<br>
<blockquote type="cite">----------messages:(3/144)----------
<br>
command: main TestVerifyDuringStartup
<br>
reason: Assumed action based on file name: run main
TestVerifyDuringStartup
<br>
elapsed time (seconds): 0.32
<br>
----------System.out:(8/408)----------
<br>
Testing:
<br>
/export/jdk8-1/solaris-x64/bin/java -XX:+UseG1GC -XX:-UseTLAB
-XX:+UnlockDiagnosticVMOptions -XX:+VerifyDuringStartup -version
<br>
Output:
<br>
[Verifying threads Roots HeapRegionSets HeapRegions RemSet syms
strs zone dict metaspace chunks hand C-heap code cache ]
<br>
java version "1.8.0-ea"
<br>
Java(TM) SE Runtime Environment (build 1.8.0-ea-b58)
<br>
Java HotSpot(TM) Server VM (build 25.0-b29-internal, mixed mode)
<br>
<br>
----------System.err:(1/15)----------
<br>
STATUS:Passed.
<br>
result: Passed. Execution successful
<br>
</blockquote>
<br>
Thanks,
<br>
<br>
JohnC
<br>
</blockquote>
<br>
</body>
</html>