<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">On 04/25/2013 07:03 PM, John
Cuthbertson wrote:<br>
</div>
<blockquote cite="mid:517961DC.7060800@oracle.com" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
Hi Stefan,<br>
<br>
Apologies - I wasn't clear. What I meant was: should
VerifySilently be explicitly disabled in the test?<br>
</blockquote>
<br>
I don't that's needed. If someone changes the test flags or the
default value, we'll find it and fix it then.<br>
<br>
StefanK<br>
<br>
<blockquote cite="mid:517961DC.7060800@oracle.com" type="cite"> <br>
JohnC<br>
<br>
<div class="moz-cite-prefix">On 4/25/2013 12:05 AM, Stefan
Karlsson wrote:<br>
</div>
<blockquote cite="mid:5178D59E.5020908@oracle.com" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
<div class="moz-cite-prefix">On 04/25/2013 02:59 AM, John
Cuthbertson wrote:<br>
</div>
<blockquote cite="mid:51787FFB.3000103@oracle.com" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
Hi Stefan,<br>
<br>
Looks fine to me.<br>
</blockquote>
<br>
Thanks, John.<br>
<br>
<blockquote cite="mid:51787FFB.3000103@oracle.com" type="cite">
<br>
One minor point - this will affect the reg test I sent out for
review yesterday which explicitly looks for "[Verifying..."<br>
</blockquote>
<br>
The flag is off by default, so this will not affect your test.
I've verified this by applying you patch.<br>
<br>
thanks,<br>
StefanK<br>
<br>
<blockquote cite="mid:51787FFB.3000103@oracle.com" type="cite">
<br>
JohnC<br>
<br>
<div class="moz-cite-prefix">On 4/24/2013 11:12 AM, Stefan
Karlsson wrote:<br>
</div>
<blockquote cite="mid:5178207E.1080209@oracle.com" type="cite">
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Estefank/8013132/webrev.00/">http://cr.openjdk.java.net/~stefank/8013132/webrev.00/</a><br>
<br>
This RFE adds a new flag named VerifySilently, which can be
used to turn off the verbose output that the verification
code produces. The proposed name has been chosen to match
other Verify flags.<br>
<br>
From the Bug description:<br>
---<br>
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
The HotSpot verification code is rather verbose and
intrusive. I propose that we add a flag that can be used to
turn this output off. <br>
<br>
An example of the verification output: <br>
<tt>$ java -XX:+PrintGC -XX:+UnlockDiagnosticVMOptions
-XX:+VerifyBeforeExit -XX:+VerifyAfterGC
-XX:+VerifyBeforeGC -XX:+UseConcMarkSweepGC
-XX:+ExplicitGCInvokesConcurrent -cp /localhome/tests/
HelloSystemGC </tt><tt><br>
</tt><tt> VerifyBeforeGC:[Verifying threads heap concurrent
mark-sweep generation par new generation remset syms strs
zone dict cldg metaspace chunks hand C-heap code cache ] </tt><tt><br>
</tt><tt> [GC (System.gc()) 672K->260K(121600K),
0.0060920 secs] </tt><tt><br>
</tt><tt> VerifyAfterGC:[Verifying threads heap concurrent
mark-sweep generation par new generation remset syms strs
zone dict cldg metaspace chunks hand C-heap code cache ] </tt><tt><br>
</tt><tt> [Verifying threads heap concurrent mark-sweep
generation par new generation remset syms strs zone dict
cldg metaspace chunks hand C-heap code cache ] </tt><tt><br>
</tt><tt> [GC (CMS Initial Mark) 260K(121600K), 0.0204040
secs] </tt><tt><br>
</tt><tt> [Verifying threads heap concurrent mark-sweep
generation par new generation remset syms strs zone dict
cldg metaspace chunks hand C-heap code cache ] </tt><tt><br>
</tt><tt> [Verifying threads heap concurrent mark-sweep
generation par new generation remset syms strs zone dict
cldg metaspace chunks hand C-heap code cache ] </tt><tt><br>
</tt><tt> [GC (CMS Final Remark) [Verifying CMS Marking...
done] 1604K(121600K), 0.1008210 secs] </tt><tt><br>
</tt><tt> [Verifying threads heap concurrent mark-sweep
generation par new generation remset syms strs zone dict
cldg metaspace chunks hand C-heap code cache ] </tt><br>
<br>
And with the proposed flag turned on: <br>
<tt>[GC (System.gc()) 672K->269K(121600K), 0.0050710
secs] </tt><tt><br>
</tt><tt> [GC (CMS Initial Mark) 269K(121600K), 0.0203380
secs] </tt><tt><br>
</tt><tt> [GC (CMS Final Remark) 1613K(121600K), 0.1007210
secs] </tt><br>
---<br>
<br>
thanks,<br>
StefanK<br>
</blockquote>
<br>
</blockquote>
<br>
</blockquote>
<br>
</blockquote>
<br>
</body>
</html>