<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix"><br>
Hi John,<br>
<br>
Missed this review request. Sorry for the late review.<br>
<br>
Thanks for providing the background and the good references to
previous webrevs!<br>
<br>
On 4/29/13 10:07 PM, John Cuthbertson wrote:<br>
</div>
<blockquote cite="mid:517ED2FC.2090309@oracle.com" type="cite">
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
Hi Everyone,<br>
<br>
Can I have a couple of volunteers review the back ports of the
changes for these two CRs:<br>
<br>
8005032: G1: Cleanup serial reference processing closures in
concurrent marking<br>
<br>
and:<br>
<br>
8009536: G1: Apache Lucene hang during reference processing<br>
<br>
The exported changesets did not apply cleanly because of some
event based tracing changes, namely CMTask::worker_id() being
changed to CMTask::task_id() and
ReferenceProcessor::process_discovered_references() returning a
value. Back porting the changes for 8005032 reduce the number of
conflicts when importing the changes for 8009536.<br>
<br>
Since the cleanup changes expose the problem fixed by 8009536, I'd
like to push both changesets together. <br>
<br>
<u>8005032: G1: Cleanup serial reference processing closures in
concurrent marking</u><br>
The webrev for the back port of 8005032 can be found at: <a
moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Ejohnc/8005032-hsx24-backport/webrev.0/">http://cr.openjdk.java.net/~johnc/8005032-hsx24-backport/webrev.0/</a>.
The original hs25 changes can be found at: <a
moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Ejohnc/8005032/webrev.1/">http://cr.openjdk.java.net/~johnc/8005032/webrev.1/</a>.<br>
<br>
Testing: GC test suite (also with ParallelGCThreads=0) and event
based tracing regression tests.<br>
</blockquote>
<br>
Looks good!<br>
<br>
<blockquote cite="mid:517ED2FC.2090309@oracle.com" type="cite"> <br>
<u>8009536: G1: Apache Lucene hang during reference processing</u><br>
The webrev for just the hsx24 back port changes (applied on top of
8005032) can be found at: <a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Ejohnc/8009536-hsx24-backport/webrev.1.8009536-hsx-backport/">http://cr.openjdk.java.net/~johnc/8009536-hsx24-backport/webrev.1.8009536-hsx-backport/</a>.
The combined webrev can be found at: <a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Ejohnc/8009536-hsx24-backport/webrev.all/">http://cr.openjdk.java.net/~johnc/8009536-hsx24-backport/webrev.all/</a><br>
<br>
The original changes for hsx25 can be found at: <a
moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Ejohnc/8009536/webrev.2/">http://cr.openjdk.java.net/~johnc/8009536/webrev.2/</a>.<br>
<br>
Testing: GC test suite, the Apache Lucene uima tests with
MarkStackSize=32K entries.<br>
</blockquote>
<br>
Looks good.<br>
<br>
One very minor nit. For hs25 you fixed one indentation of a "}" that
you did not fix in hs24. :)<br>
<br>
hs24, concurrentMark.cpp - new file<br>
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
<br>
2160 }<br>
<br>
<br>
hs25, concurrentMark.cpp - new file<br>
<br>
2276 }<br>
<br>
<br>
Ship it!<br>
Bengt<br>
<br>
<blockquote cite="mid:517ED2FC.2090309@oracle.com" type="cite"> <br>
Thanks,<br>
<br>
JohnC<br>
</blockquote>
<br>
</body>
</html>