<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix"><br>
Hi Erik,<br>
<br>
Looks good.<br>
<br>
Two minor nits:<br>
<br>
Could we make 0.05 into a flag or at least a declared constant?<br>
<br>
Could we rename
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
_used_heap_in_words to something like _total_size_in_words or
_base_size_in_words since it is not really the used count for the
heap?<br>
<br>
Thanks,<br>
Bengt<br>
<br>
On 5/7/13 10:14 AM, Erik Helin wrote:<br>
</div>
<blockquote cite="mid:5188B800.4080708@oracle.com" type="cite">Hi
all,
<br>
<br>
this change makes sure that we only send the trace event
vm/gc/detailed/object_count_after_gc if the total size of all the
instances of a class occupies more than 0.5% of the used heap.
<br>
<br>
Webrev:
<br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~ehelin/8012086/webrev.00/">http://cr.openjdk.java.net/~ehelin/8012086/webrev.00/</a>
<br>
<br>
Testing:
<br>
JPRT
<br>
<br>
Thanks,
<br>
Erik
<br>
</blockquote>
<br>
</body>
</html>